Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(13)

Issue 1758783002: Revert of Reduce ActiveDOMObjects from modules/mediastream/ (Closed)

Created:
4 years, 9 months ago by haraken
Modified:
4 years, 9 months ago
CC:
chromium-reviews, blink-reviews, tommyw+watchlist_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Revert of Reduce ActiveDOMObjects from modules/mediastream/ (patchset #2 id:20001 of https://codereview.chromium.org/1744133002/ ) Reason for revert: I noticed that we're not ready to remove the m_stopped variable (because LifecycleObserver does not yet have an ability to clear LifecycleObserver::m_context when the context is destroyed). We need to fix the LifecycleObserver before landing this fix. Original issue's description: > Reduce ActiveDOMObjects from modules/mediastream/ > > Per the plan described in https://groups.google.com/a/chromium.org/d/topic/blink-dev/UwRGJgLBElo/discussion, > this CL replaces ActiveDOMObjects in modules/mediastream/ with ContextLifecycleObservers. > > BUG=589507 > > Committed: https://crrev.com/bd162ec5dcf4377d94bc08b871a64945a2793612 > Cr-Commit-Position: refs/heads/master@{#378336} TBR=tommi@chromium.org,sigbjornf@opera.com,guidou@chromium.org # Not skipping CQ checks because original CL landed more than 1 days ago. BUG=589507 Committed: https://crrev.com/e9eefb1702897cb6e5e907fa25461950e9d55774 Cr-Commit-Position: refs/heads/master@{#378763}

Patch Set 1 #

Unified diffs Side-by-side diffs Delta from patch set Stats (+82 lines, -45 lines) Patch
M third_party/WebKit/Source/modules/mediacapturefromelement/CanvasCaptureMediaStreamTrack.cpp View 3 chunks +3 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaDevicesRequest.h View 3 chunks +5 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaDevicesRequest.cpp View 3 chunks +10 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.h View 4 chunks +5 lines, -2 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/MediaStreamTrack.cpp View 5 chunks +13 lines, -5 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCDTMFSender.h View 4 chunks +6 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCDTMFSender.cpp View 4 chunks +10 lines, -6 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCStatsRequestImpl.h View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCStatsRequestImpl.cpp View 3 chunks +6 lines, -4 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCVoidRequestImpl.h View 3 chunks +4 lines, -3 lines 0 comments Download
M third_party/WebKit/Source/modules/mediastream/RTCVoidRequestImpl.cpp View 3 chunks +6 lines, -4 lines 0 comments Download

Messages

Total messages: 9 (2 generated)
haraken
Created Revert of Reduce ActiveDOMObjects from modules/mediastream/
4 years, 9 months ago (2016-03-02 16:03:14 UTC) #1
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758783002/1
4 years, 9 months ago (2016-03-02 16:03:26 UTC) #2
sof
lgtm
4 years, 9 months ago (2016-03-02 16:04:29 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758783002/1
4 years, 9 months ago (2016-03-02 16:31:35 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1758783002/1 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1758783002/1
4 years, 9 months ago (2016-03-02 17:01:35 UTC) #5
commit-bot: I haz the power
Committed patchset #1 (id:1)
4 years, 9 months ago (2016-03-02 17:16:52 UTC) #7
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 17:18:09 UTC) #9
Message was sent while issue was closed.
Patchset 1 (id:??) landed as
https://crrev.com/e9eefb1702897cb6e5e907fa25461950e9d55774
Cr-Commit-Position: refs/heads/master@{#378763}

Powered by Google App Engine
This is Rietveld 408576698