Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(16)

Side by Side Diff: third_party/WebKit/Source/modules/mediastream/RTCDTMFSender.cpp

Issue 1758783002: Revert of Reduce ActiveDOMObjects from modules/mediastream/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2013 Google Inc. All rights reserved. 2 * Copyright (C) 2013 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 1. Redistributions of source code must retain the above copyright 7 * 1. Redistributions of source code must retain the above copyright
8 * notice, this list of conditions and the following disclaimer. 8 * notice, this list of conditions and the following disclaimer.
9 * 2. Redistributions in binary form must reproduce the above copyright 9 * 2. Redistributions in binary form must reproduce the above copyright
10 * notice, this list of conditions and the following disclaimer in the 10 * notice, this list of conditions and the following disclaimer in the
(...skipping 33 matching lines...) Expand 10 before | Expand all | Expand 10 after
44 static const int defaultInterToneGapMs = 50; 44 static const int defaultInterToneGapMs = 50;
45 45
46 RTCDTMFSender* RTCDTMFSender::create(ExecutionContext* context, WebRTCPeerConnec tionHandler* peerConnectionHandler, MediaStreamTrack* track, ExceptionState& exc eptionState) 46 RTCDTMFSender* RTCDTMFSender::create(ExecutionContext* context, WebRTCPeerConnec tionHandler* peerConnectionHandler, MediaStreamTrack* track, ExceptionState& exc eptionState)
47 { 47 {
48 OwnPtr<WebRTCDTMFSenderHandler> handler = adoptPtr(peerConnectionHandler->cr eateDTMFSender(track->component())); 48 OwnPtr<WebRTCDTMFSenderHandler> handler = adoptPtr(peerConnectionHandler->cr eateDTMFSender(track->component()));
49 if (!handler) { 49 if (!handler) {
50 exceptionState.throwDOMException(NotSupportedError, "The MediaStreamTrac k provided is not an element of a MediaStream that's currently in the local stre ams set."); 50 exceptionState.throwDOMException(NotSupportedError, "The MediaStreamTrac k provided is not an element of a MediaStream that's currently in the local stre ams set.");
51 return nullptr; 51 return nullptr;
52 } 52 }
53 53
54 return new RTCDTMFSender(context, track, handler.release()); 54 RTCDTMFSender* dtmfSender = new RTCDTMFSender(context, track, handler.releas e());
55 dtmfSender->suspendIfNeeded();
56 return dtmfSender;
55 } 57 }
56 58
57 RTCDTMFSender::RTCDTMFSender(ExecutionContext* context, MediaStreamTrack* track, PassOwnPtr<WebRTCDTMFSenderHandler> handler) 59 RTCDTMFSender::RTCDTMFSender(ExecutionContext* context, MediaStreamTrack* track, PassOwnPtr<WebRTCDTMFSenderHandler> handler)
58 : ContextLifecycleObserver(context) 60 : ActiveDOMObject(context)
59 , m_track(track) 61 , m_track(track)
60 , m_duration(defaultToneDurationMs) 62 , m_duration(defaultToneDurationMs)
61 , m_interToneGap(defaultInterToneGapMs) 63 , m_interToneGap(defaultInterToneGapMs)
62 , m_handler(handler) 64 , m_handler(handler)
65 , m_stopped(false)
63 , m_scheduledEventTimer(this, &RTCDTMFSender::scheduledEventTimerFired) 66 , m_scheduledEventTimer(this, &RTCDTMFSender::scheduledEventTimerFired)
64 { 67 {
65 m_handler->setClient(this); 68 m_handler->setClient(this);
66 } 69 }
67 70
68 RTCDTMFSender::~RTCDTMFSender() 71 RTCDTMFSender::~RTCDTMFSender()
69 { 72 {
70 } 73 }
71 74
72 bool RTCDTMFSender::canInsertDTMF() const 75 bool RTCDTMFSender::canInsertDTMF() const
(...skipping 50 matching lines...) Expand 10 before | Expand all | Expand 10 after
123 scheduleDispatchEvent(RTCDTMFToneChangeEvent::create(tone)); 126 scheduleDispatchEvent(RTCDTMFToneChangeEvent::create(tone));
124 } 127 }
125 128
126 const AtomicString& RTCDTMFSender::interfaceName() const 129 const AtomicString& RTCDTMFSender::interfaceName() const
127 { 130 {
128 return EventTargetNames::RTCDTMFSender; 131 return EventTargetNames::RTCDTMFSender;
129 } 132 }
130 133
131 ExecutionContext* RTCDTMFSender::executionContext() const 134 ExecutionContext* RTCDTMFSender::executionContext() const
132 { 135 {
133 return ContextLifecycleObserver::executionContext(); 136 return ActiveDOMObject::executionContext();
134 } 137 }
135 138
136 void RTCDTMFSender::contextDestroyed() 139 void RTCDTMFSender::stop()
137 { 140 {
141 m_stopped = true;
138 m_handler->setClient(0); 142 m_handler->setClient(0);
139 } 143 }
140 144
141 void RTCDTMFSender::scheduleDispatchEvent(PassRefPtrWillBeRawPtr<Event> event) 145 void RTCDTMFSender::scheduleDispatchEvent(PassRefPtrWillBeRawPtr<Event> event)
142 { 146 {
143 m_scheduledEvents.append(event); 147 m_scheduledEvents.append(event);
144 148
145 if (!m_scheduledEventTimer.isActive()) 149 if (!m_scheduledEventTimer.isActive())
146 m_scheduledEventTimer.startOneShot(0, BLINK_FROM_HERE); 150 m_scheduledEventTimer.startOneShot(0, BLINK_FROM_HERE);
147 } 151 }
148 152
149 void RTCDTMFSender::scheduledEventTimerFired(Timer<RTCDTMFSender>*) 153 void RTCDTMFSender::scheduledEventTimerFired(Timer<RTCDTMFSender>*)
150 { 154 {
151 if (!executionContext()) 155 if (m_stopped)
152 return; 156 return;
153 157
154 WillBeHeapVector<RefPtrWillBeMember<Event>> events; 158 WillBeHeapVector<RefPtrWillBeMember<Event>> events;
155 events.swap(m_scheduledEvents); 159 events.swap(m_scheduledEvents);
156 160
157 WillBeHeapVector<RefPtrWillBeMember<Event>>::iterator it = events.begin(); 161 WillBeHeapVector<RefPtrWillBeMember<Event>>::iterator it = events.begin();
158 for (; it != events.end(); ++it) 162 for (; it != events.end(); ++it)
159 dispatchEvent((*it).release()); 163 dispatchEvent((*it).release());
160 } 164 }
161 165
162 DEFINE_TRACE(RTCDTMFSender) 166 DEFINE_TRACE(RTCDTMFSender)
163 { 167 {
164 visitor->trace(m_track); 168 visitor->trace(m_track);
165 visitor->trace(m_scheduledEvents); 169 visitor->trace(m_scheduledEvents);
166 RefCountedGarbageCollectedEventTargetWithInlineData<RTCDTMFSender>::trace(vi sitor); 170 RefCountedGarbageCollectedEventTargetWithInlineData<RTCDTMFSender>::trace(vi sitor);
167 ContextLifecycleObserver::trace(visitor); 171 ActiveDOMObject::trace(visitor);
168 } 172 }
169 173
170 } // namespace blink 174 } // namespace blink
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698