third_party/WebKit/Source/modules/mediastream/RTCVoidRequestImpl.h - Issue 1758783002: Revert of Reduce ActiveDOMObjects from modules/mediastream/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCVoidRequestImpl.h

Issue 1758783002: Revert of Reduce ActiveDOMObjects from modules/mediastream/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/RTCStatsRequestImpl.cpp ('k') | third_party/WebKit/Source/modules/mediastream/RTCVoidRequestImpl.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/RTCVoidRequestImpl.h

diff --git a/third_party/WebKit/Source/modules/mediastream/RTCVoidRequestImpl.h b/third_party/WebKit/Source/modules/mediastream/RTCVoidRequestImpl.h

index 08302331973d8eea517912472ecca61c2a402fcc..22e56e2b4630d52d5af6e2c8b6452ff4b5750d0e 100644

--- a/third_party/WebKit/Source/modules/mediastream/RTCVoidRequestImpl.h

+++ b/third_party/WebKit/Source/modules/mediastream/RTCVoidRequestImpl.h

@@ -31,7 +31,7 @@

#ifndef RTCVoidRequestImpl_h

#define RTCVoidRequestImpl_h

-#include "core/dom/ContextLifecycleObserver.h"

+#include "core/dom/ActiveDOMObject.h"

#include "core/dom/ExceptionCode.h"

#include "platform/heap/Handle.h"

#include "platform/mediastream/RTCVoidRequest.h"

@@ -42,7 +42,7 @@

class RTCPeerConnectionErrorCallback;

class VoidCallback;

-class RTCVoidRequestImpl final : public RTCVoidRequest, public ContextLifecycleObserver {

+class RTCVoidRequestImpl final : public RTCVoidRequest, public ActiveDOMObject {

WILL_BE_USING_GARBAGE_COLLECTED_MIXIN(RTCVoidRequestImpl);

public:

static RTCVoidRequestImpl* create(ExecutionContext*, RTCPeerConnection*, VoidCallback*, RTCPeerConnectionErrorCallback*);

@@ -52,7 +52,8 @@

void requestSucceeded() override;

void requestFailed(const String& error) override;

- void contextDestroyed() override;

+ // ActiveDOMObject

+ void stop() override;

DECLARE_VIRTUAL_TRACE();