Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(853)

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCStatsRequestImpl.cpp

Issue 1758783002: Revert of Reduce ActiveDOMObjects from modules/mediastream/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/modules/mediastream/RTCStatsRequestImpl.cpp
diff --git a/third_party/WebKit/Source/modules/mediastream/RTCStatsRequestImpl.cpp b/third_party/WebKit/Source/modules/mediastream/RTCStatsRequestImpl.cpp
index 040370f9f340106fae38425720199c24727f1ffa..0c2e38bd2a466866a2052b360b6cfb493b24b4d1 100644
--- a/third_party/WebKit/Source/modules/mediastream/RTCStatsRequestImpl.cpp
+++ b/third_party/WebKit/Source/modules/mediastream/RTCStatsRequestImpl.cpp
@@ -32,11 +32,13 @@
RTCStatsRequestImpl* RTCStatsRequestImpl::create(ExecutionContext* context, RTCPeerConnection* requester, RTCStatsCallback* callback, MediaStreamTrack* selector)
{
- return new RTCStatsRequestImpl(context, requester, callback, selector);
+ RTCStatsRequestImpl* request = new RTCStatsRequestImpl(context, requester, callback, selector);
+ request->suspendIfNeeded();
+ return request;
}
RTCStatsRequestImpl::RTCStatsRequestImpl(ExecutionContext* context, RTCPeerConnection* requester, RTCStatsCallback* callback, MediaStreamTrack* selector)
- : ContextLifecycleObserver(context)
+ : ActiveDOMObject(context)
, m_successCallback(callback)
, m_component(selector ? selector->component() : 0)
, m_requester(requester)
@@ -71,7 +73,7 @@
clear();
}
-void RTCStatsRequestImpl::contextDestroyed()
+void RTCStatsRequestImpl::stop()
{
clear();
}
@@ -88,7 +90,7 @@
visitor->trace(m_component);
visitor->trace(m_requester);
RTCStatsRequest::trace(visitor);
- ContextLifecycleObserver::trace(visitor);
+ ActiveDOMObject::trace(visitor);
}
} // namespace blink

Powered by Google App Engine
This is Rietveld 408576698