third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp - Issue 1758783002: Revert of Reduce ActiveDOMObjects from modules/mediastream/

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp

Issue 1758783002: Revert of Reduce ActiveDOMObjects from modules/mediastream/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.h ('k') | third_party/WebKit/Source/modules/mediastream/RTCStatsRequestImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp

diff --git a/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp b/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp

index c5b5e64c07418011ce687a8d20ba88bd1e4f5d30..29463de6a741e13ee8fcbc97c5d7ade900f81e5f 100644

--- a/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp

+++ b/third_party/WebKit/Source/modules/mediastream/RTCSessionDescriptionRequestImpl.cpp

@@ -43,11 +43,13 @@

RTCSessionDescriptionRequestImpl* RTCSessionDescriptionRequestImpl::create(ExecutionContext* context, RTCPeerConnection* requester, RTCSessionDescriptionCallback* successCallback, RTCPeerConnectionErrorCallback* errorCallback)

{

- return new RTCSessionDescriptionRequestImpl(context, requester, successCallback, errorCallback);

+ RTCSessionDescriptionRequestImpl* request = new RTCSessionDescriptionRequestImpl(context, requester, successCallback, errorCallback);

+ request->suspendIfNeeded();

+ return request;

}

RTCSessionDescriptionRequestImpl::RTCSessionDescriptionRequestImpl(ExecutionContext* context, RTCPeerConnection* requester, RTCSessionDescriptionCallback* successCallback, RTCPeerConnectionErrorCallback* errorCallback)

- : ContextLifecycleObserver(context)

+ : ActiveDOMObject(context)

, m_successCallback(successCallback)

, m_errorCallback(errorCallback)

, m_requester(requester)

@@ -76,7 +78,7 @@

clear();

}

-void RTCSessionDescriptionRequestImpl::contextDestroyed()

+void RTCSessionDescriptionRequestImpl::stop()

{

clear();

}

@@ -94,7 +96,7 @@

visitor->trace(m_errorCallback);

visitor->trace(m_requester);

RTCSessionDescriptionRequest::trace(visitor);

- ContextLifecycleObserver::trace(visitor);

+ ActiveDOMObject::trace(visitor);

}

} // namespace blink