Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(103)

Side by Side Diff: third_party/WebKit/Source/modules/mediastream/RTCVoidRequestImpl.cpp

Issue 1758783002: Revert of Reduce ActiveDOMObjects from modules/mediastream/ (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Created 4 years, 9 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/RTCVoidRequestImpl.h ('k') | no next file » | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 2012 Google Inc. All rights reserved. 2 * Copyright (C) 2012 Google Inc. All rights reserved.
3 * 3 *
4 * Redistribution and use in source and binary forms, with or without 4 * Redistribution and use in source and binary forms, with or without
5 * modification, are permitted provided that the following conditions 5 * modification, are permitted provided that the following conditions
6 * are met: 6 * are met:
7 * 7 *
8 * 1. Redistributions of source code must retain the above copyright 8 * 1. Redistributions of source code must retain the above copyright
9 * notice, this list of conditions and the following disclaimer. 9 * notice, this list of conditions and the following disclaimer.
10 * 2. Redistributions in binary form must reproduce the above copyright 10 * 2. Redistributions in binary form must reproduce the above copyright
(...skipping 22 matching lines...) Expand all
33 #include "core/dom/DOMException.h" 33 #include "core/dom/DOMException.h"
34 #include "core/dom/ExceptionCode.h" 34 #include "core/dom/ExceptionCode.h"
35 #include "core/html/VoidCallback.h" 35 #include "core/html/VoidCallback.h"
36 #include "modules/mediastream/RTCPeerConnection.h" 36 #include "modules/mediastream/RTCPeerConnection.h"
37 #include "modules/mediastream/RTCPeerConnectionErrorCallback.h" 37 #include "modules/mediastream/RTCPeerConnectionErrorCallback.h"
38 38
39 namespace blink { 39 namespace blink {
40 40
41 RTCVoidRequestImpl* RTCVoidRequestImpl::create(ExecutionContext* context, RTCPee rConnection* requester, VoidCallback* successCallback, RTCPeerConnectionErrorCal lback* errorCallback) 41 RTCVoidRequestImpl* RTCVoidRequestImpl::create(ExecutionContext* context, RTCPee rConnection* requester, VoidCallback* successCallback, RTCPeerConnectionErrorCal lback* errorCallback)
42 { 42 {
43 return new RTCVoidRequestImpl(context, requester, successCallback, errorCall back); 43 RTCVoidRequestImpl* request = new RTCVoidRequestImpl(context, requester, suc cessCallback, errorCallback);
44 request->suspendIfNeeded();
45 return request;
44 } 46 }
45 47
46 RTCVoidRequestImpl::RTCVoidRequestImpl(ExecutionContext* context, RTCPeerConnect ion* requester, VoidCallback* successCallback, RTCPeerConnectionErrorCallback* e rrorCallback) 48 RTCVoidRequestImpl::RTCVoidRequestImpl(ExecutionContext* context, RTCPeerConnect ion* requester, VoidCallback* successCallback, RTCPeerConnectionErrorCallback* e rrorCallback)
47 : ContextLifecycleObserver(context) 49 : ActiveDOMObject(context)
48 , m_successCallback(successCallback) 50 , m_successCallback(successCallback)
49 , m_errorCallback(errorCallback) 51 , m_errorCallback(errorCallback)
50 , m_requester(requester) 52 , m_requester(requester)
51 { 53 {
52 ASSERT(m_requester); 54 ASSERT(m_requester);
53 } 55 }
54 56
55 RTCVoidRequestImpl::~RTCVoidRequestImpl() 57 RTCVoidRequestImpl::~RTCVoidRequestImpl()
56 { 58 {
57 } 59 }
(...skipping 11 matching lines...) Expand all
69 { 71 {
70 bool shouldFireCallback = m_requester && m_requester->shouldFireDefaultCallb acks(); 72 bool shouldFireCallback = m_requester && m_requester->shouldFireDefaultCallb acks();
71 if (shouldFireCallback && m_errorCallback.get()) { 73 if (shouldFireCallback && m_errorCallback.get()) {
72 // TODO(guidou): The error code should come from the content layer. See crbug.com/589455 74 // TODO(guidou): The error code should come from the content layer. See crbug.com/589455
73 m_errorCallback->handleEvent(DOMException::create(OperationError, error) ); 75 m_errorCallback->handleEvent(DOMException::create(OperationError, error) );
74 } 76 }
75 77
76 clear(); 78 clear();
77 } 79 }
78 80
79 void RTCVoidRequestImpl::contextDestroyed() 81 void RTCVoidRequestImpl::stop()
80 { 82 {
81 clear(); 83 clear();
82 } 84 }
83 85
84 void RTCVoidRequestImpl::clear() 86 void RTCVoidRequestImpl::clear()
85 { 87 {
86 m_successCallback.clear(); 88 m_successCallback.clear();
87 m_errorCallback.clear(); 89 m_errorCallback.clear();
88 m_requester.clear(); 90 m_requester.clear();
89 } 91 }
90 92
91 DEFINE_TRACE(RTCVoidRequestImpl) 93 DEFINE_TRACE(RTCVoidRequestImpl)
92 { 94 {
93 visitor->trace(m_successCallback); 95 visitor->trace(m_successCallback);
94 visitor->trace(m_errorCallback); 96 visitor->trace(m_errorCallback);
95 visitor->trace(m_requester); 97 visitor->trace(m_requester);
96 RTCVoidRequest::trace(visitor); 98 RTCVoidRequest::trace(visitor);
97 ContextLifecycleObserver::trace(visitor); 99 ActiveDOMObject::trace(visitor);
98 } 100 }
99 101
100 } // namespace blink 102 } // namespace blink
OLDNEW
« no previous file with comments | « third_party/WebKit/Source/modules/mediastream/RTCVoidRequestImpl.h ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698