CORS-RFC1918: Teach ResourceRequest about "external" requests

CORS-RFC1918: Teach ResourceRequest about "external" requests

As defined in https://mikewest.github.io/cors-rfc1918/#external-request.
This patch converts the "reserved IP range" flag on 'ResourceRequest'
into an "external request" flag, and ensures that the flag is set
correctly for requests that run through 'ThreadableLoader' and
'ResourceFetcher'.

The new flag is locked to a new RuntimeEnabledFeature, which is enabled
in test only. If that feature isn't enabled, no request is marked as
being external.

BUG=591052
Committed: https://crrev.com/dc5e487ba33a18f6e0362e072af8c5a39552dffa
Cr-Commit-Position: refs/heads/master@{#378730}

[Mike West, 2016-03-01 14:59:00]

Description was changed from

==========
CORS-RFC1918: Teach ResourceRequest about "external" requests

As defined in https://mikewest.github.io/cors-rfc1918/#external-request.
This patch converts the "reserved IP range" flag on 'ResourceRequest'
into an "external request" flag, and ensures that the flag is set
correctly for requests that run through 'ThreadableLoader' and
'ResourceFetcher'.

BUG=591052
==========

to

==========
CORS-RFC1918: Teach ResourceRequest about "external" requests

As defined in https://mikewest.github.io/cors-rfc1918/#external-request.
This patch converts the "reserved IP range" flag on 'ResourceRequest'
into an "external request" flag, and ensures that the flag is set
correctly for requests that run through 'ThreadableLoader' and
'ResourceFetcher'.

The new flag is locked to a new RuntimeEnabledFeature, which is enabled
in test only. If that feature isn't enabled, no request is marked as
being external.

BUG=591052
==========

[Mike West, 2016-03-01 14:59:00]

mkwst@chromium.org changed reviewers:
+ jochen@chromium.org

[Mike West, 2016-03-01 14:59:08]

Mind taking a look, Jochen?

[jochen (gone - plz use gerrit), 2016-03-01 15:42:29]

https://codereview.chromium.org/1749153002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/network/ResourceRequest.cpp (right):

https://codereview.chromium.org/1749153002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/network/ResourceRequest.cpp:451:
m_isExternalRequest = false;
should this default to true if the runtime flag is on?

https://codereview.chromium.org/1749153002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/network/ResourceRequest.h (right):

https://codereview.chromium.org/1749153002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/network/ResourceRequest.h:245: void
setIsExternalRequest(bool contextHostedInReservedIPRange);
if I read setIsExternalRequest(true) somewhere in the source, I'd expect that it
marks this request as external.

maybe this should be called something like
markRequestAsExternalDependingOnRequestContext and take an enum arg
(ContextIsPublicInternet, ContextIsPrivateInternet, ContextIsLocalhost)?

[Mike West, 2016-03-02 08:50:03]

https://codereview.chromium.org/1749153002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/network/ResourceRequest.cpp (right):

https://codereview.chromium.org/1749153002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/network/ResourceRequest.cpp:451:
m_isExternalRequest = false;
On 2016/03/01 at 15:42:29, jochen wrote:
> should this default to true if the runtime flag is on?

I don't think so, because we'll end up using this for navigations as well, and
need to ensure that top-level navigations that are user-initiated (address bar,
bookmark, etc) don't force preflights. It seems like the right way to do that is
for the default to be non-external, and only change the setting if we're in the
context of a document (as we do in FrameFetchContext).

https://codereview.chromium.org/1749153002/diff/1/third_party/WebKit/Source/p...
File third_party/WebKit/Source/platform/network/ResourceRequest.h (right):

https://codereview.chromium.org/1749153002/diff/1/third_party/WebKit/Source/p...
third_party/WebKit/Source/platform/network/ResourceRequest.h:245: void
setIsExternalRequest(bool contextHostedInReservedIPRange);
On 2016/03/01 at 15:42:29, jochen wrote:
> if I read setIsExternalRequest(true) somewhere in the source, I'd expect that
it marks this request as external.
> 
> maybe this should be called something like
markRequestAsExternalDependingOnRequestContext and take an enum arg
(ContextIsPublicInternet, ContextIsPrivateInternet, ContextIsLocalhost)?

Yup. Completely reworked this as an AddressSpace enum on WebURLRequest. WDYT?

[jochen (gone - plz use gerrit), 2016-03-02 11:02:26]

lgtm

[Mike West, 2016-03-02 12:01:25]

The CQ bit was checked by mkwst@chromium.org

[commit-bot: I haz the power, 2016-03-02 12:01:36]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1749153002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1749153002/20001

[commit-bot: I haz the power, 2016-03-02 12:07:46]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-03-02 12:09:10]

Description was changed from

==========
CORS-RFC1918: Teach ResourceRequest about "external" requests

As defined in https://mikewest.github.io/cors-rfc1918/#external-request.
This patch converts the "reserved IP range" flag on 'ResourceRequest'
into an "external request" flag, and ensures that the flag is set
correctly for requests that run through 'ThreadableLoader' and
'ResourceFetcher'.

The new flag is locked to a new RuntimeEnabledFeature, which is enabled
in test only. If that feature isn't enabled, no request is marked as
being external.

BUG=591052
==========

to

==========
CORS-RFC1918: Teach ResourceRequest about "external" requests

As defined in https://mikewest.github.io/cors-rfc1918/#external-request.
This patch converts the "reserved IP range" flag on 'ResourceRequest'
into an "external request" flag, and ensures that the flag is set
correctly for requests that run through 'ThreadableLoader' and
'ResourceFetcher'.

The new flag is locked to a new RuntimeEnabledFeature, which is enabled
in test only. If that feature isn't enabled, no request is marked as
being external.

BUG=591052

Committed: https://crrev.com/dc5e487ba33a18f6e0362e072af8c5a39552dffa
Cr-Commit-Position: refs/heads/master@{#378730}
==========

[commit-bot: I haz the power, 2016-03-02 12:09:12]

Patchset 2 (id:??) landed as
https://crrev.com/dc5e487ba33a18f6e0362e072af8c5a39552dffa
Cr-Commit-Position: refs/heads/master@{#378730}