third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp - Issue 1749153002: CORS-RFC1918: Teach ResourceRequest about "external" requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp

Issue 1749153002: CORS-RFC1918: Teach ResourceRequest about "external" requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Jochen's feedback. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/xmlhttprequest/XMLHttpRequest.cpp ('k') | third_party/WebKit/Source/modules/fetch/FetchManager.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp b/third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp

index 01016800c2ca73813452f96c551ce9436ff36c43..156ebe31d5d71f679f6558ab08295f135f87d265 100644

--- a/third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp

+++ b/third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp

@@ -96,6 +96,7 @@ public:

ResourceRequest request(url);

request.setRequestContext(WebURLRequest::RequestContextInternal);

request.setUseStreamOnResponse(true);

+ // We intentionally skip 'setExternalRequestStateFromRequestorAddressSpace', as 'data:' can never be external.

m_loader->start(request);

}