third_party/WebKit/Source/modules/fetch/FetchManager.cpp - Issue 1749153002: CORS-RFC1918: Teach ResourceRequest about "external" requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

Issue 1749153002: CORS-RFC1918: Teach ResourceRequest about "external" requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Jochen's feedback. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/fetch/FetchBlobDataConsumerHandle.cpp ('k') | third_party/WebKit/Source/platform/RuntimeEnabledFeatures.in » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/fetch/FetchManager.cpp

diff --git a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

index a2feca286d4fac6b90ebd11df2fe58138934cb6c..83e5de31acb2bbcb1270aa3ddb732b464687797c 100644

--- a/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

+++ b/third_party/WebKit/Source/modules/fetch/FetchManager.cpp

@@ -538,6 +538,7 @@ void FetchManager::Loader::performHTTPFetch(bool corsFlag, bool corsPreflightFla

}

request.setFetchRedirectMode(m_request->redirect());

request.setUseStreamOnResponse(true);

+ request.setExternalRequestStateFromRequestorAddressSpace(executionContext()->securityContext().addressSpace());

// "2. Append `Referer`/empty byte sequence, if |HTTPRequest|'s |referrer|

// is none, and `Referer`/|HTTPRequest|'s referrer, serialized and utf-8

@@ -633,6 +634,7 @@ void FetchManager::Loader::performDataFetch()

request.setUseStreamOnResponse(true);

request.setHTTPMethod(m_request->method());

request.setFetchRedirectMode(WebURLRequest::FetchRedirectModeError);

+ // We intentionally skip 'setExternalRequestStateFromRequestorAddressSpace', as 'data:' can never be external.

ResourceLoaderOptions resourceLoaderOptions;

resourceLoaderOptions.dataBufferingPolicy = DoNotBufferData;