Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(749)

Issue 1747263002: CORS-RFC1918: Introduce 'treat-as-public-address' CSP directive (Closed)

Created:
4 years, 9 months ago by Mike West
Modified:
4 years, 9 months ago
CC:
blink-reviews, chromium-reviews, mkwst+watchlist-csp_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@iprange
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

CORS-RFC1918: Introduce 'treat-as-public-address' CSP directive As defined at https://mikewest.github.io/cors-rfc1918/#csp, this CSP directive allows a document to drop any "external request" privileges it might have based on the IP address from which it was served. This flag isn't used yet, but will be once we start teaching the various loaders about the joys and sorrows of external requests. BUG=591056 Committed: https://crrev.com/81fb72f0982740ece29d016e1853561f8e04c8eb Cr-Commit-Position: refs/heads/master@{#378735}

Patch Set 1 #

Patch Set 2 : feedback/rebase #

Unified diffs Side-by-side diffs Delta from patch set Stats (+64 lines, -1 line) Patch
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.h View 1 2 chunks +2 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/CSPDirectiveList.cpp View 1 3 chunks +19 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.h View 1 3 chunks +5 lines, -0 lines 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicy.cpp View 1 5 chunks +15 lines, -1 line 0 comments Download
M third_party/WebKit/Source/core/frame/csp/ContentSecurityPolicyTest.cpp View 1 2 chunks +23 lines, -0 lines 0 comments Download

Depends on Patchset:

Dependent Patchsets:

Messages

Total messages: 10 (5 generated)
Mike West
Just verified with a unit-test at the moment. Will be present in layout tests as ...
4 years, 9 months ago (2016-03-01 15:22:09 UTC) #2
jochen (gone - plz use gerrit)
lgtm
4 years, 9 months ago (2016-03-01 15:34:49 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1747263002/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1747263002/20001
4 years, 9 months ago (2016-03-02 12:23:47 UTC) #7
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 9 months ago (2016-03-02 13:29:03 UTC) #8
commit-bot: I haz the power
4 years, 9 months ago (2016-03-02 13:30:15 UTC) #10
Message was sent while issue was closed.
Patchset 2 (id:??) landed as
https://crrev.com/81fb72f0982740ece29d016e1853561f8e04c8eb
Cr-Commit-Position: refs/heads/master@{#378735}

Powered by Google App Engine
This is Rietveld 408576698