third_party/WebKit/Source/core/page/EventSource.cpp - Issue 1749153002: CORS-RFC1918: Teach ResourceRequest about "external" requests

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/page/EventSource.cpp

Issue 1749153002: CORS-RFC1918: Teach ResourceRequest about "external" requests (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Jochen's feedback. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/loader/MixedContentChecker.cpp ('k') | third_party/WebKit/Source/core/workers/WorkerScriptLoader.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/page/EventSource.cpp

diff --git a/third_party/WebKit/Source/core/page/EventSource.cpp b/third_party/WebKit/Source/core/page/EventSource.cpp

index 6f5f3f83bd1b13d13b89cfca00b8f18deba3fca7..cf342912299860176b78f57bbbe48a15d5e8b425 100644

--- a/third_party/WebKit/Source/core/page/EventSource.cpp

+++ b/third_party/WebKit/Source/core/page/EventSource.cpp

@@ -121,6 +121,7 @@ void EventSource::connect()

request.setHTTPHeaderField(HTTPNames::Accept, "text/event-stream");

request.setHTTPHeaderField(HTTPNames::Cache_Control, "no-cache");

request.setRequestContext(WebURLRequest::RequestContextEventSource);

+ request.setExternalRequestStateFromRequestorAddressSpace(executionContext.securityContext().addressSpace());

if (m_parser && !m_parser->lastEventId().isEmpty()) {

// HTTP headers are Latin-1 byte strings, but the Last-Event-ID header is encoded as UTF-8.

// TODO(davidben): This should be captured in the type of setHTTPHeaderField's arguments.