CORS-RFC1918: Teach ResourceRequest about "external" requests

third_party/WebKit/Source/platform/network/ResourceRequest.h

 /*
  * Copyright (C) 2003, 2006 Apple Computer, Inc.  All rights reserved.
  * Copyright (C) 2006 Samuel Weinig <sam.weinig@gmail.com>
  * Copyright (C) 2009, 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions
  * are met:
  * 1. Redistributions of source code must retain the above copyright
  *    notice, this list of conditions and the following disclaimer.
@@ skipping 23 matching lines @@
 #include "platform/network/HTTPParsers.h"
 #include "platform/network/ResourceLoadPriority.h"
 #include "platform/weborigin/KURL.h"
 #include "platform/weborigin/Referrer.h"
 #include "platform/weborigin/SecurityOrigin.h"
 #include "public/platform/WebURLRequest.h"
 #include "wtf/OwnPtr.h"
 
 namespace blink {
 
+class SecurityContext;
+
 enum ResourceRequestCachePolicy {
     UseProtocolCachePolicy, // normal load
     ReloadIgnoringCacheData, // reload
     ReturnCacheDataElseLoad, // back/forward or encoding change - allow stale data
     ReturnCacheDataDontLoad, // results of a post - allow stale data and only use cache
     ReloadBypassingCache, // end-to-end reload
 };
 
 enum ResourceRequestBlockedReason {
     ResourceRequestBlockedReasonCSP,
@@ skipping 177 matching lines @@
     bool hasCacheValidatorFields() const;
 
     static bool compare(const ResourceRequest&, const ResourceRequest&);
 
     bool checkForBrowserSideNavigation() const { return m_checkForBrowserSideNavigation; }
     void setCheckForBrowserSideNavigation(bool check) { m_checkForBrowserSideNavigation = check; }
 
     double uiStartTime() const { return m_uiStartTime; }
     void setUIStartTime(double uiStartTime) { m_uiStartTime = uiStartTime; }
 
-    bool originatesFromReservedIPRange() const { return m_originatesFromReservedIPRange; }
-    void setOriginatesFromReservedIPRange(bool value) { m_originatesFromReservedIPRange = value; }
+    // https://mikewest.github.io/cors-rfc1918/#external-request
+    bool isExternalRequest() const { return m_isExternalRequest; }
+    void setIsExternalRequest(bool contextHostedInReservedIPRange);

[jochen (gone - plz use gerrit), 2016/03/01 15:42:29]

if I read setIsExternalRequest(true) somewhere in the source, I'd expect that it
marks this request as external.

maybe this should be called something like
markRequestAsExternalDependingOnRequestContext and take an enum arg
(ContextIsPublicInternet, ContextIsPrivateInternet, ContextIsLocalhost)?

[Mike West, 2016/03/02 08:50:03]

Yup. Completely reworked this as an AddressSpace enum on WebURLRequest. WDYT?

 
     InputToLoadPerfMetricReportPolicy inputPerfMetricReportPolicy() const { return m_inputPerfMetricReportPolicy; }
     void setInputPerfMetricReportPolicy(InputToLoadPerfMetricReportPolicy inputPerfMetricReportPolicy) { m_inputPerfMetricReportPolicy = inputPerfMetricReportPolicy; }
 
     void setFollowedRedirect(bool followed) { m_followedRedirect = followed; }
     bool followedRedirect() const { return m_followedRedirect; }
 
 private:
     void initialize(const KURL&);
 
@@ skipping 24 matching lines @@
     WebURLRequest::RequestContext m_requestContext;
     WebURLRequest::FrameType m_frameType;
     WebURLRequest::FetchRequestMode m_fetchRequestMode;
     WebURLRequest::FetchCredentialsMode m_fetchCredentialsMode;
     WebURLRequest::FetchRedirectMode m_fetchRedirectMode;
     WebURLRequest::LoFiState m_loFiState;
     ReferrerPolicy m_referrerPolicy;
     bool m_didSetHTTPReferrer;
     bool m_checkForBrowserSideNavigation;
     double m_uiStartTime;
-    bool m_originatesFromReservedIPRange;
+    bool m_isExternalRequest;
     InputToLoadPerfMetricReportPolicy m_inputPerfMetricReportPolicy;
 
     mutable CacheControlHeader m_cacheControlHeaderCache;
 
     static double s_defaultTimeoutInterval;
 
     bool m_followedRedirect;
 };
 
 bool equalIgnoringHeaderFields(const ResourceRequest&, const ResourceRequest&);
@@ skipping 30 matching lines @@
     WebURLRequest::RequestContext m_requestContext;
     WebURLRequest::FrameType m_frameType;
     WebURLRequest::FetchRequestMode m_fetchRequestMode;
     WebURLRequest::FetchCredentialsMode m_fetchCredentialsMode;
     WebURLRequest::FetchRedirectMode m_fetchRedirectMode;
     WebURLRequest::LoFiState m_loFiState;
     ReferrerPolicy m_referrerPolicy;
     bool m_didSetHTTPReferrer;
     bool m_checkForBrowserSideNavigation;
     double m_uiStartTime;
-    bool m_originatesFromReservedIPRange;
+    bool m_isExternalRequest;
     InputToLoadPerfMetricReportPolicy m_inputPerfMetricReportPolicy;
     bool m_followedRedirect;
 };
 
 } // namespace blink
 
 #endif // ResourceRequest_h