[TBMv2] Fix page deserialization

[TBMv2] Fix page deserialization

This CL fixes a TBMv2 bug that actually turned out to be a legitimate Telemetry
bug: when you attempt deserialize a page with ID 0 Python's implicit conersions
were stymying us, and this strengthens the check to `is not None` and adds some
tests.

It also changes the method of setting the page ID in translate_common_values to be less 'clever'

BUG=catapult:#2070
R=nednguyen

Committed: https://chromium.googlesource.com/external/github.com/catapult-project/catapult/+/a489be785184f64356555a8170452a6d6880cc5d

[nednguyen, 2016-02-26 20:35:49]

lgtm with nits

https://codereview.chromium.org/1741063002/diff/1/telemetry/telemetry/value/t...
File telemetry/telemetry/value/translate_common_values.py (right):

https://codereview.chromium.org/1741063002/diff/1/telemetry/telemetry/value/t...
telemetry/telemetry/value/translate_common_values.py:35: return
scalar.ScalarValue.FromDict(scalar_value, {0: page})
{page.id: page}

[eakuefner, 2016-02-26 20:37:45]

Description was changed from

==========
[TBMv2] Allow deserialization of page ID 0

This CL fixes a TBMv2 bug that actually turned out to be a legitimate Telemetry
bug: when you attempt deserialize a page with ID 0 Python's implicit conersions
were stymying us, and this strengthens the check to `is not None` and adds some
tests.

BUG=catapult:#2070
R=nednguyen
==========

to

==========
[TBMv2] Fix page deserialization

This CL fixes a TBMv2 bug that actually turned out to be a legitimate Telemetry
bug: when you attempt deserialize a page with ID 0 Python's implicit conersions
were stymying us, and this strengthens the check to `is not None` and adds some
tests.

It also changes the method of setting the page ID in translate_common_values to
be less 'clever'

BUG=catapult:#2070
R=nednguyen
==========

[eakuefner, 2016-02-26 20:38:40]

https://codereview.chromium.org/1741063002/diff/1/telemetry/telemetry/value/t...
File telemetry/telemetry/value/translate_common_values.py (right):

https://codereview.chromium.org/1741063002/diff/1/telemetry/telemetry/value/t...
telemetry/telemetry/value/translate_common_values.py:35: return
scalar.ScalarValue.FromDict(scalar_value, {0: page})
On 2016/02/26 at 20:35:49, nednguyen wrote:
> {page.id: page}

Done. Also updated description.

[eakuefner, 2016-02-26 20:38:43]

The CQ bit was checked by eakuefner@chromium.org

[eakuefner, 2016-02-26 20:38:43]

The patchset sent to the CQ was uploaded after l-g-t-m from nednguyen@google.com
Link to the patchset: https://codereview.chromium.org/1741063002/#ps20001
(title: "Address Ned's comment")

[commit-bot: I haz the power, 2016-02-26 20:38:49]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1741063002/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1741063002/20001

[commit-bot: I haz the power, 2016-02-26 20:49:56]

Description was changed from

==========
[TBMv2] Fix page deserialization

This CL fixes a TBMv2 bug that actually turned out to be a legitimate Telemetry
bug: when you attempt deserialize a page with ID 0 Python's implicit conersions
were stymying us, and this strengthens the check to `is not None` and adds some
tests.

It also changes the method of setting the page ID in translate_common_values to
be less 'clever'

BUG=catapult:#2070
R=nednguyen
==========

to

==========
[TBMv2] Fix page deserialization

This CL fixes a TBMv2 bug that actually turned out to be a legitimate Telemetry
bug: when you attempt deserialize a page with ID 0 Python's implicit conersions
were stymying us, and this strengthens the check to `is not None` and adds some
tests.

It also changes the method of setting the page ID in translate_common_values to
be less 'clever'

BUG=catapult:#2070
R=nednguyen

Committed:
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...
==========

[commit-bot: I haz the power, 2016-02-26 20:49:57]

Committed patchset #2 (id:20001) as
https://chromium.googlesource.com/external/github.com/catapult-project/catapu...