Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(634)

Unified Diff: telemetry/telemetry/value/value_unittest.py

Issue 1741063002: [TBMv2] Fix page deserialization (Closed) Base URL: git@github.com:catapult-project/catapult.git@master
Patch Set: Address Ned's comment Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: telemetry/telemetry/value/value_unittest.py
diff --git a/telemetry/telemetry/value/value_unittest.py b/telemetry/telemetry/value/value_unittest.py
index 193c273b37dd7fe76742da53f435257fa3c65d38..9cf9a4c767e307f4189859679fb4fec44981fa5c 100644
--- a/telemetry/telemetry/value/value_unittest.py
+++ b/telemetry/telemetry/value/value_unittest.py
@@ -217,6 +217,20 @@ class ValueTest(TestBase):
self.assertEquals(v.page.id, page0.id)
+ def testFromDictWithPageId0(self):
+ page_dict = {0: 'foo'}
+
+ d = {
+ 'type': 'value_for_from_dict_test',
+ 'name': 'x',
+ 'units': 'unit',
+ 'page_id': 0
+ }
+
+ v = value.Value.FromDict(d, page_dict)
+
+ self.assertEquals(v.page, 'foo')
+
def testFromDictWithoutPage(self):
d = {
'type': 'value_for_from_dict_test',

Powered by Google App Engine
This is Rietveld 408576698