telemetry/telemetry/value/__init__.py - Issue 1741063002: [TBMv2] Fix page deserialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/value/init.py

Issue 1741063002: [TBMv2] Fix page deserialization (Closed) Base URL: git@github.com:catapult-project/catapult.git@master

Patch Set: Address Ned's comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/value/__init__.py

diff --git a/telemetry/telemetry/value/__init__.py b/telemetry/telemetry/value/__init__.py

index e4381117025e37c10a17ce45e6c4d5876a11cf98..dbd7085da49a74eac37859b88959fe4310497ca9 100644

--- a/telemetry/telemetry/value/__init__.py

+++ b/telemetry/telemetry/value/__init__.py

@@ -297,7 +297,7 @@ class Value(object):

d['description'] = None

page_id = value_dict.get('page_id', None)

- if page_id:

+ if page_id is not None:

d['page'] = page_dict[int(page_id)]

else:

d['page'] = None

« no previous file with comments | « no previous file | telemetry/telemetry/value/translate_common_values.py » ('j') | no next file with comments »