telemetry/telemetry/value/translate_common_values.py - Issue 1741063002: [TBMv2] Fix page deserialization

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: telemetry/telemetry/value/translate_common_values.py

Issue 1741063002: [TBMv2] Fix page deserialization (Closed) Base URL: git@github.com:catapult-project/catapult.git@master

Patch Set: Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View unified diff | Download patch

« no previous file with comments | « telemetry/telemetry/value/__init__.py ('k') | telemetry/telemetry/value/value_unittest.py » ('j') | no next file with comments »

OLD	NEW
1 # Copyright 2016 The Chromium Authors. All rights reserved.	1 # Copyright 2016 The Chromium Authors. All rights reserved.

2 # Use of this source code is governed by a BSD-style license that can be	2 # Use of this source code is governed by a BSD-style license that can be

3 # found in the LICENSE file.	3 # found in the LICENSE file.

4 from telemetry.value import failure	4 from telemetry.value import failure

5 from telemetry.value import improvement_direction	5 from telemetry.value import improvement_direction

6 from telemetry.value import scalar	6 from telemetry.value import scalar

7	7

8	8

9 def TranslateMreFailure(mre_failure, page):	9 def TranslateMreFailure(mre_failure, page):

10 return failure.FailureValue.FromMessage(page, mre_failure.stack)	10 return failure.FailureValue.FromMessage(page, mre_failure.stack)

(...skipping 11 matching lines...) Expand all Loading...
22 raise ValueError('Must specify improvement direction for value ' + name)	22 raise ValueError('Must specify improvement direction for value ' + name)

23	23

24 scalar_value['units'] = unit_parts[0]	24 scalar_value['units'] = unit_parts[0]

25	25

26 if unit_parts[1] == 'biggerIsBetter':	26 if unit_parts[1] == 'biggerIsBetter':

27 scalar_value['improvement_direction'] = improvement_direction.UP	27 scalar_value['improvement_direction'] = improvement_direction.UP

28 else:	28 else:

29 assert unit_parts[1] == 'smallerIsBetter'	29 assert unit_parts[1] == 'smallerIsBetter'

30 scalar_value['improvement_direction'] = improvement_direction.DOWN	30 scalar_value['improvement_direction'] = improvement_direction.DOWN

31	31

32 scalar_value['page'] = page	32 scalar_value['page_id'] = 0

33 scalar_value['name'] = name	33 scalar_value['name'] = name

34 del scalar_value['grouping_keys']['name']	34 del scalar_value['grouping_keys']['name']

35 return scalar.ScalarValue.FromDict(scalar_value, {})	35 return scalar.ScalarValue.FromDict(scalar_value, {0: page})
	nednguyen 2016/02/26 20:35:49 {page.id: page} {page.id: page} eakuefner 2016/02/26 20:38:39 Done. Also updated description. Show quoted text On 2016/02/26 at 20:35:49, nednguyen wrote: > {page.id: page} Done. Also updated description.
OLD	NEW