telemetry/telemetry/value/translate_common_values.py - Issue 1741063002: [TBMv2] Fix page deserialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/value/translate_common_values.py

Issue 1741063002: [TBMv2] Fix page deserialization (Closed) Base URL: git@github.com:catapult-project/catapult.git@master

Patch Set: Address Ned's comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/value/translate_common_values.py

diff --git a/telemetry/telemetry/value/translate_common_values.py b/telemetry/telemetry/value/translate_common_values.py

index f5a3cdcb90bc51911ad60c0c5de298f5f46183d0..b9bdfe03c345d5690d5b6f05f5441cca67fd7e66 100644

--- a/telemetry/telemetry/value/translate_common_values.py

+++ b/telemetry/telemetry/value/translate_common_values.py

@@ -29,7 +29,7 @@ def TranslateScalarValue(scalar_value, page):

assert unit_parts[1] == 'smallerIsBetter'

scalar_value['improvement_direction'] = improvement_direction.DOWN

- scalar_value['page'] = page

+ scalar_value['page_id'] = page.id

scalar_value['name'] = name

del scalar_value['grouping_keys']['name']

- return scalar.ScalarValue.FromDict(scalar_value, {})

+ return scalar.ScalarValue.FromDict(scalar_value, {page.id: page})

« no previous file with comments | « telemetry/telemetry/value/__init__.py ('k') | telemetry/telemetry/value/value_unittest.py » ('j') | no next file with comments »