telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py - Issue 1741063002: [TBMv2] Fix page deserialization

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py

Issue 1741063002: [TBMv2] Fix page deserialization (Closed) Base URL: git@github.com:catapult-project/catapult.git@master

Patch Set: Address Ned's comment Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py

diff --git a/telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py b/telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py

index 414b5814a394d90f576e8bbb565fef8882d4449e..f902ecf952e6b3161ce0aaf6030acebf5da999de 100644

--- a/telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py

+++ b/telemetry/telemetry/web_perf/timeline_based_page_test_unittest.py

@@ -150,4 +150,6 @@ class TimelineBasedPageTestTest(page_test_test_case.PageTestTestCase):

self.assertEquals(len(v_foo), 1)

self.assertEquals(len(v_bar), 1)

self.assertEquals(v_foo[0].value, 1)

+ self.assertIsNotNone(v_foo[0].page)

self.assertEquals(v_bar[0].value, 2)

+ self.assertIsNotNone(v_bar[0].page)

« no previous file with comments | « telemetry/telemetry/value/value_unittest.py ('k') | no next file » | no next file with comments »