Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(705)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 174073007: Remove deprecated window.showModalDialog() (Closed)

Created:
6 years, 10 months ago by jamesr
Modified:
6 years, 10 months ago
Reviewers:
abarth-chromium
CC:
blink-reviews, shans, apavlov+blink_chromium.org, adamk+blink_chromium.org, loislo+blink_chromium.org, aandrey+blink_chromium.org, dino_apple.com, Nils Barth (inactive), caseq+blink_chromium.org, Steve Block, arv+blink, alancutter (OOO until 2018), pfeldman+blink_chromium.org, yurys+blink_chromium.org, abarth-chromium, dstockwell, Timothy Loh, devtools-reviews_chromium.org, Eric Willigers, marja+watch_chromium.org, rjwright, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, kojih, darktears, haraken, Nate Chapin, jsbell+bindings_chromium.org, alph+blink_chromium.org, vsevik+blink_chromium.org, Mike Lawther (Google), Inactive, watchdog-blink-watchlist_google.com
Visibility:
Public.

Description

Remove deprecated window.showModalDialog() Time to go. BUG=345831 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167736

Patch Set 1 #

Patch Set 2 : Delete some more #

Patch Set 3 : #

Unified diffs Side-by-side diffs Delta from patch set Stats (+12 lines, -657 lines) Patch
M LayoutTests/TestExpectations View 1 2 1 chunk +0 lines, -5 lines 0 comments Download
D LayoutTests/fast/animation/request-animation-frame-during-modal.html View 1 chunk +0 lines, -42 lines 0 comments Download
D LayoutTests/fast/animation/request-animation-frame-during-modal-expected.txt View 1 chunk +0 lines, -17 lines 0 comments Download
D LayoutTests/fast/dom/Window/open-window-min-size.html View 1 chunk +0 lines, -33 lines 0 comments Download
D LayoutTests/fast/dom/Window/open-window-min-size-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M LayoutTests/fast/dom/Window/resources/WindowProperties.js View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/Window/resources/window-properties.js View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/dom/Window/showModalDialog-invalid-arguments.html View 1 chunk +0 lines, -20 lines 0 comments Download
D LayoutTests/fast/dom/Window/showModalDialog-invalid-arguments-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-function-frame-getter-precedence.html View 1 chunk +1 line, -7 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-function-name-getter-precedence.html View 1 chunk +1 line, -7 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-lookup-precedence.html View 1 chunk +0 lines, -3 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-property-shadowing.html View 1 chunk +0 lines, -2 lines 0 comments Download
M LayoutTests/fast/dom/Window/window-property-shadowing-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/dom/null-page-show-modal-dialog-crash.html View 1 chunk +0 lines, -25 lines 0 comments Download
D LayoutTests/fast/dom/null-page-show-modal-dialog-crash-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/resources/wrapper-identity-base.js View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/dom/wrapper-identity-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
D LayoutTests/fast/events/scroll-event-during-modal-dialog.html View 1 chunk +0 lines, -39 lines 0 comments Download
D LayoutTests/fast/events/scroll-event-during-modal-dialog-expected.txt View 1 chunk +0 lines, -13 lines 0 comments Download
D LayoutTests/fast/events/show-modal-dialog-onblur-onfocus.html View 1 chunk +0 lines, -47 lines 0 comments Download
D LayoutTests/fast/events/show-modal-dialog-onblur-onfocus-expected.txt View 1 chunk +0 lines, -8 lines 0 comments Download
D LayoutTests/fast/harness/show-modal-dialog.html View 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/fast/harness/show-modal-dialog-expected.txt View 1 chunk +0 lines, -6 lines 0 comments Download
M LayoutTests/fast/js/function-length.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/js/function-length-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/fast/js/global-function-resolve-expected.txt View 1 chunk +6 lines, -8 lines 0 comments Download
M LayoutTests/fast/js/script-tests/global-function-resolve.js View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-call.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-call-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-get.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-get-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-getOwnPropertyDescriptor.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-getOwnPropertyDescriptor-expected.txt View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-put.html View 1 chunk +0 lines, -1 line 0 comments Download
M LayoutTests/http/tests/security/cross-frame-access-put-expected.txt View 2 chunks +0 lines, -2 lines 0 comments Download
M LayoutTests/http/tests/security/resources/cross-frame-iframe-for-put-test.html View 2 chunks +0 lines, -4 lines 0 comments Download
D LayoutTests/inspector/console/console-long-eval-crash.html View 1 chunk +0 lines, -31 lines 0 comments Download
D LayoutTests/inspector/console/console-long-eval-crash-expected.txt View 1 chunk +0 lines, -4 lines 0 comments Download
D LayoutTests/platform/mac/fast/dom/Window/open-window-min-size-expected.txt View 1 chunk +0 lines, -9 lines 0 comments Download
M LayoutTests/platform/win/http/tests/security/README View 1 chunk +0 lines, -1 line 0 comments Download
M ManualTests/js-timers-beneath-modal-dialog.html View 2 chunks +1 line, -3 lines 0 comments Download
D ManualTests/modal-dialog-arguments.html View 1 chunk +0 lines, -19 lines 0 comments Download
D ManualTests/modal-dialog-blur.html View 1 chunk +0 lines, -34 lines 0 comments Download
D ManualTests/show-modal-dialog-test.html View 1 chunk +0 lines, -15 lines 0 comments Download
D ManualTests/showModalDialog-returnValue.html View 1 chunk +0 lines, -13 lines 0 comments Download
M Source/bindings/v8/custom/V8WindowCustom.cpp View 1 1 chunk +0 lines, -62 lines 0 comments Download
M Source/core/frame/DOMWindow.h View 2 chunks +0 lines, -6 lines 0 comments Download
M Source/core/frame/DOMWindow.cpp View 1 2 2 chunks +0 lines, -46 lines 0 comments Download
M Source/core/frame/Window.idl View 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/loader/EmptyClients.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/page/Chrome.h View 1 1 chunk +0 lines, -4 lines 0 comments Download
M Source/core/page/Chrome.cpp View 1 2 chunks +0 lines, -20 lines 0 comments Download
M Source/core/page/ChromeClient.h View 1 2 1 chunk +0 lines, -3 lines 0 comments Download
M Source/core/page/CreateWindow.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/page/CreateWindow.cpp View 1 2 chunks +1 line, -4 lines 0 comments Download
M Source/web/ChromeClientImpl.h View 1 2 1 chunk +0 lines, -2 lines 0 comments Download
M Source/web/ChromeClientImpl.cpp View 1 2 2 chunks +1 line, -12 lines 0 comments Download
M public/web/WebWidgetClient.h View 1 1 chunk +0 lines, -4 lines 0 comments Download

Messages

Total messages: 13 (0 generated)
jamesr
Here's a happy patch. I sent an intent to remove to blink-dev. I believe I'll ...
6 years, 10 months ago (2014-02-21 02:39:14 UTC) #1
abarth-chromium
LGTM Amazing
6 years, 10 months ago (2014-02-21 07:45:49 UTC) #2
jamesr
I found some additional code to delete in these files: Source/core/page/ChromeClient.h Source/core/page/Chrome.cpp Source/core/page/CreateWindow.cpp Source/web/ChromeClientImpl.h Source/core/loader/EmptyClients.h ...
6 years, 10 months ago (2014-02-21 22:44:02 UTC) #3
abarth-chromium
LGTM There's more code to remove also, but we can get that code in later ...
6 years, 10 months ago (2014-02-21 23:14:08 UTC) #4
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 10 months ago (2014-02-24 21:53:29 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/174073007/230001
6 years, 10 months ago (2014-02-24 21:53:36 UTC) #6
commit-bot: I haz the power
The CQ bit was unchecked by commit-bot@chromium.org
6 years, 10 months ago (2014-02-24 23:34:10 UTC) #7
commit-bot: I haz the power
Retried try job too often on win_blink_rel for step(s) webkit_lint, webkit_python_tests, webkit_tests http://build.chromium.org/p/tryserver.chromium/buildstatus?builder=win_blink_rel&number=28721
6 years, 10 months ago (2014-02-24 23:34:11 UTC) #8
jamesr
The CQ bit was checked by jamesr@chromium.org
6 years, 10 months ago (2014-02-24 23:34:52 UTC) #9
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/174073007/230001
6 years, 10 months ago (2014-02-24 23:35:04 UTC) #10
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/174073007/230001
6 years, 10 months ago (2014-02-25 01:09:42 UTC) #11
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/jamesr@chromium.org/174073007/230001
6 years, 10 months ago (2014-02-25 05:17:43 UTC) #12
commit-bot: I haz the power
6 years, 10 months ago (2014-02-25 06:54:28 UTC) #13
Message was sent while issue was closed. 
Change committed as 167736

Powered by Google App Engine
This is Rietveld 408576698