Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2171)

Unified Diff: Source/web/ChromeClientImpl.cpp

Issue 174073007: Remove deprecated window.showModalDialog() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/web/ChromeClientImpl.h ('k') | public/web/WebWidgetClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/web/ChromeClientImpl.cpp
diff --git a/Source/web/ChromeClientImpl.cpp b/Source/web/ChromeClientImpl.cpp
index bdeaa8f1b7f11f2d8a4b8a561e6ef21f270690d2..6504a202fb8ced24081c5d0290429adcd0a1a849 100644
--- a/Source/web/ChromeClientImpl.cpp
+++ b/Source/web/ChromeClientImpl.cpp
@@ -297,17 +297,6 @@ void ChromeClientImpl::show(NavigationPolicy navigationPolicy)
m_webView->client()->show(policy);
}
-bool ChromeClientImpl::canRunModal()
-{
- return !!m_webView->client();
-}
-
-void ChromeClientImpl::runModal()
-{
- if (m_webView->client())
- m_webView->client()->runModal();
-}
-
void ChromeClientImpl::setToolbarsVisible(bool value)
{
m_toolbarsVisible = value;
@@ -796,7 +785,7 @@ void ChromeClientImpl::openPasswordGenerator(HTMLInputElement* input)
bool ChromeClientImpl::shouldRunModalDialogDuringPageDismissal(const DialogType& dialogType, const String& dialogMessage, Document::PageDismissalType dismissalType) const
{
- const char* kDialogs[] = {"alert", "confirm", "prompt", "showModalDialog"};
+ const char* kDialogs[] = {"alert", "confirm", "prompt"};
int dialog = static_cast<int>(dialogType);
ASSERT_WITH_SECURITY_IMPLICATION(0 <= dialog && dialog < static_cast<int>(arraysize(kDialogs)));
« no previous file with comments | « Source/web/ChromeClientImpl.h ('k') | public/web/WebWidgetClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698