Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(868)

Unified Diff: Source/core/page/CreateWindow.cpp

Issue 174073007: Remove deprecated window.showModalDialog() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/CreateWindow.h ('k') | Source/web/ChromeClientImpl.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/CreateWindow.cpp
diff --git a/Source/core/page/CreateWindow.cpp b/Source/core/page/CreateWindow.cpp
index fbb21966c30609ff04d281db4b6a1459130e2403..0110cbefacbf29a28faf1074eba5c70a6550efa6 100644
--- a/Source/core/page/CreateWindow.cpp
+++ b/Source/core/page/CreateWindow.cpp
@@ -114,7 +114,7 @@ static Frame* createWindow(Frame* openerFrame, Frame* lookupFrame, const FrameLo
}
Frame* createWindow(const String& urlString, const AtomicString& frameName, const WindowFeatures& windowFeatures,
- DOMWindow* callingWindow, Frame* firstFrame, Frame* openerFrame, DOMWindow::PrepareDialogFunction function, void* functionContext)
+ DOMWindow* callingWindow, Frame* firstFrame, Frame* openerFrame)
{
Frame* activeFrame = callingWindow->frame();
@@ -145,9 +145,6 @@ Frame* createWindow(const String& urlString, const AtomicString& frameName, cons
if (newFrame->domWindow()->isInsecureScriptAccess(callingWindow, completedURL))
return newFrame;
- if (function)
- function(newFrame->domWindow(), functionContext);
-
if (created) {
FrameLoadRequest request(callingWindow->document(), ResourceRequest(completedURL, referrer));
newFrame->loader().load(request);
« no previous file with comments | « Source/core/page/CreateWindow.h ('k') | Source/web/ChromeClientImpl.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698