Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1270)

Unified Diff: Source/core/page/Chrome.cpp

Issue 174073007: Remove deprecated window.showModalDialog() (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « Source/core/page/Chrome.h ('k') | Source/core/page/ChromeClient.h » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: Source/core/page/Chrome.cpp
diff --git a/Source/core/page/Chrome.cpp b/Source/core/page/Chrome.cpp
index 2f05ab2f92af49f7716677bf8a0eb7bc02ec353d..3abc6bec2d8816275056494411edf223deec5198 100644
--- a/Source/core/page/Chrome.cpp
+++ b/Source/core/page/Chrome.cpp
@@ -135,11 +135,6 @@ void Chrome::show(NavigationPolicy policy) const
m_client->show(policy);
}
-bool Chrome::canRunModal() const
-{
- return m_client->canRunModal();
-}
-
static bool canRunModalIfDuringPageDismissal(Page* page, ChromeClient::DialogType dialog, const String& message)
{
for (Frame* frame = page->mainFrame(); frame; frame = frame->tree().traverseNext()) {
@@ -150,21 +145,6 @@ static bool canRunModalIfDuringPageDismissal(Page* page, ChromeClient::DialogTyp
return true;
}
-bool Chrome::canRunModalNow() const
-{
- return canRunModal() && canRunModalIfDuringPageDismissal(m_page, ChromeClient::HTMLDialog, String());
-}
-
-void Chrome::runModal() const
-{
- // Defer callbacks in all the other pages, so we don't try to run JavaScript
- // in a way that could interact with this view.
- ScopedPageLoadDeferrer deferrer(m_page);
-
- TimerBase::fireTimersInNestedEventLoop();
- m_client->runModal();
-}
-
void Chrome::setWindowFeatures(const WindowFeatures& features) const
{
m_client->setToolbarsVisible(features.toolBarVisible || features.locationBarVisible);
« no previous file with comments | « Source/core/page/Chrome.h ('k') | Source/core/page/ChromeClient.h » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698