LayoutTests/fast/dom/null-page-show-modal-dialog-crash.html - Issue 174073007: Remove deprecated window.showModalDialog()

Side by Side Diff

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Side by Side Diff: LayoutTests/fast/dom/null-page-show-modal-dialog-crash.html

Issue 174073007: Remove deprecated window.showModalDialog() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

OLD	NEW
	(Empty)
1 This is a test for <a href="https://bugs.webkit.org/show_bug.cgi?id=19541">https ://bugs.webkit.org/show_bug.cgi?id=19541</a>

2 RBug 19541: Null pointer in showModalDialog()

3

4 This tests calling the showModalDialog() function on a window object from a deta ched iframe, both calling the saved showModalDialog() function and getting the p roperty again after the iframe has been detached.

5

6 If there is no crash this test passes.

7 <script type="text/javascript">

8 if (window.testRunner)

9 testRunner.dumpAsText();

10

11 var iframe = document.createElement("iframe");

12

13 iframe.onload = function() {

14 var iframeWindow = iframe.contentWindow;

15 var f = iframeWindow.showModalDialog;

16

17 iframe.parentNode.removeChild(iframe);

18 if (iframeWindow.showModalDialog)

19 iframeWindow.showModalDialog();

20 if (f)

21 f.call(iframeWindow);

22 };

23

24 document.body.appendChild(iframe);

25 </script>

OLD	NEW