ManualTests/js-timers-beneath-modal-dialog.html - Issue 174073007: Remove deprecated window.showModalDialog()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ManualTests/js-timers-beneath-modal-dialog.html

Issue 174073007: Remove deprecated window.showModalDialog() (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: ManualTests/js-timers-beneath-modal-dialog.html

diff --git a/ManualTests/js-timers-beneath-modal-dialog.html b/ManualTests/js-timers-beneath-modal-dialog.html

index 6d5f2c7edf81aba675f2cd631b82df52c1e5e5e8..65e26a21799ef2db5256abdbbb017e02dc5ae5a7 100644

--- a/ManualTests/js-timers-beneath-modal-dialog.html

+++ b/ManualTests/js-timers-beneath-modal-dialog.html

@@ -1,5 +1,4 @@

-<p>JS timers should be paused while a modal dialog (or alert) is displayed.</p>

-<p>Please disable popup blocker for this test.</p>

+<p>JS timers should be paused while an alert is displayed.</p>

function f()

@@ -11,7 +10,6 @@ function f()

var timerId = setInterval(f, 100);

alert("Numbers in main window should not increase while this alert is displayed");

-showModalDialog("data:text/html,<p>Numbers in main window should not increase while this modal dialog is displayed</p>");

document.getElementsByTagName("div")[0].innerHTML = "DONE";

clearInterval(timerId);