DevTools: validate protocol input parameters.

DevTools: validate protocol input parameters.

BUG=580337
Committed: https://crrev.com/029e9a50ad13cec7e61d8ff530c3800510ac654f
Cr-Commit-Position: refs/heads/master@{#377787}

[pfeldman, 2016-02-25 16:39:58]

pfeldman@chromium.org changed reviewers:
+ dgozman@chromium.org

[pfeldman, 2016-02-25 16:41:33]

The CQ bit was checked by pfeldman@chromium.org to run a CQ dry run

[commit-bot: I haz the power, 2016-02-25 16:43:58]

Dry run: CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1739613002/40001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1739613002/40001

[dgozman, 2016-02-25 21:40:37]

lgtm

https://codereview.chromium.org/1739613002/diff/60001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp
(right):

https://codereview.chromium.org/1739613002/diff/60001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorLayerTreeAgent.cpp:416: return
true;
No need to return anything. Could just inline this whole function.

https://codereview.chromium.org/1739613002/diff/80001/third_party/WebKit/Sour...
File third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp
(right):

https://codereview.chromium.org/1739613002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp:118: return
protocol::FromValue<protocol::Network::Headers>::parse(headersObject, &errors);
protocol::Network::Headers::parse(...)

https://codereview.chromium.org/1739613002/diff/80001/third_party/WebKit/Sour...
File
third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_cpp.template
(right):

https://codereview.chromium.org/1739613002/diff/80001/third_party/WebKit/Sour...
third_party/WebKit/Source/platform/inspector_protocol/Dispatcher_cpp.template:124:
errors->addError("Inspector handler is not available.");
Can we say {{domain.domain}} handler is not available?

https://codereview.chromium.org/1739613002/diff/100001/third_party/WebKit/Sou...
File
third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template
(right):

https://codereview.chromium.org/1739613002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template:306:
return nullptr;
Should errors->pop() before return. Or better just don't push nullptr into array
and validate the rest of input.

https://codereview.chromium.org/1739613002/diff/100001/third_party/WebKit/Sou...
third_party/WebKit/Source/platform/inspector_protocol/TypeBuilder_h.template:340:
class PLATFORM_EXPORT Object {
No need for export.

[pfeldman, 2016-02-25 22:09:23]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-02-25 22:09:24]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1739613002/#ps120001
(title: "review comments addressed")

[pfeldman, 2016-02-25 22:09:31]

All Done.

[commit-bot: I haz the power, 2016-02-25 22:15:29]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1739613002/120001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1739613002/120001

[commit-bot: I haz the power, 2016-02-25 23:28:59]

The CQ bit was unchecked by commit-bot@chromium.org

[commit-bot: I haz the power, 2016-02-25 23:29:01]

Try jobs failed on following builders:
  mac_chromium_rel_ng on tryserver.chromium.mac (JOB_FAILED,
http://build.chromium.org/p/tryserver.chromium.mac/builders/mac_chromium_rel_...)

[pfeldman, 2016-02-26 00:13:40]

The CQ bit was checked by pfeldman@chromium.org

[pfeldman, 2016-02-26 00:13:41]

The patchset sent to the CQ was uploaded after l-g-t-m from dgozman@chromium.org
Link to the patchset: https://codereview.chromium.org/1739613002/#ps140001
(title: "rebaselined a test.")

[commit-bot: I haz the power, 2016-02-26 00:25:08]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1739613002/140001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1739613002/140001

[commit-bot: I haz the power, 2016-02-26 02:56:47]

Committed patchset #8 (id:140001)

[commit-bot: I haz the power, 2016-02-26 02:57:51]

Description was changed from

==========
DevTools: validate protocol input parameters.

BUG=580337
==========

to

==========
DevTools: validate protocol input parameters.

BUG=580337

Committed: https://crrev.com/029e9a50ad13cec7e61d8ff530c3800510ac654f
Cr-Commit-Position: refs/heads/master@{#377787}
==========

[commit-bot: I haz the power, 2016-02-26 02:57:52]

Patchset 8 (id:??) landed as
https://crrev.com/029e9a50ad13cec7e61d8ff530c3800510ac654f
Cr-Commit-Position: refs/heads/master@{#377787}