Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(118)

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp

Issue 1739613002: DevTools: validate protocol input parameters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: rebaselined a test. Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp
diff --git a/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp
index d1333510b5851c4a654672a546e53492f0ef37c0..d26d586aef83da7911a29ae9db4b8e6502a8d35e 100644
--- a/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp
+++ b/third_party/WebKit/Source/core/inspector/InspectorResourceAgent.cpp
@@ -114,7 +114,8 @@ static PassOwnPtr<protocol::Network::Headers> buildObjectForHeaders(const HTTPHe
RefPtr<JSONObject> headersObject = JSONObject::create();
for (const auto& header : headers)
headersObject->setString(header.key.string(), header.value);
- return protocol::FromValue<protocol::Network::Headers>::convert(headersObject);
+ protocol::ErrorSupport errors;
+ return protocol::Network::Headers::parse(headersObject, &errors);
}
class InspectorFileReaderLoaderClient final : public FileReaderLoaderClient {
@@ -897,7 +898,7 @@ void InspectorResourceAgent::setUserAgentOverride(ErrorString*, const String& us
void InspectorResourceAgent::setExtraHTTPHeaders(ErrorString*, const PassOwnPtr<protocol::Network::Headers> headers)
{
- m_state->setObject(ResourceAgentState::extraRequestHeaders, headers->asValue());
+ m_state->setObject(ResourceAgentState::extraRequestHeaders, headers->serialize());
}
bool InspectorResourceAgent::getResponseBodyBlob(const String& requestId, PassRefPtr<GetResponseBodyCallback> callback)

Powered by Google App Engine
This is Rietveld 408576698