third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp - Issue 1739613002: DevTools: validate protocol input parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

Issue 1739613002: DevTools: validate protocol input parameters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined a test. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/core/inspector/InspectorDOMAgent.cpp ('k') | third_party/WebKit/Source/core/inspector/InspectorHighlight.cpp » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

diff --git a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

index e49c67ae5978a43d6428914b444c665a3414115e..8b72cabf48079783aba5479d36dda9b724e8a439 100644

--- a/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

+++ b/third_party/WebKit/Source/core/inspector/InspectorDOMDebuggerAgent.cpp

@@ -467,7 +467,7 @@ void InspectorDOMDebuggerAgent::descriptionForDOMEvent(Node* target, int breakpo

// For inheritable breakpoint types, target node isn't always the same as the node that owns a breakpoint.

// Target node may be unknown to frontend, so we need to push it first.

OwnPtr<protocol::Runtime::RemoteObject> targetNodeObject = m_domAgent->resolveNode(target, V8DebuggerAgent::backtraceObjectGroup);

- description->setValue("targetNode", targetNodeObject->asValue());

+ description->setValue("targetNode", targetNodeObject->serialize());

// Find breakpoint owner node.

if (!insertion)