DevTools: validate protocol input parameters.

third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp

 /*
  * Copyright (C) 2012 Google Inc. All rights reserved.
  *
  * Redistribution and use in source and binary forms, with or without
  * modification, are permitted provided that the following conditions are
  * met:
  *
  *     * Redistributions of source code must retain the above copyright
  * notice, this list of conditions and the following disclaimer.
  *     * Redistributions in binary form must reproduce the above
@@ skipping 337 matching lines @@
     }
 
     RequestCallback* requestCallback() override { return m_requestCallback.get(); }
 private:
     DatabaseLoader(ScriptState* scriptState, PassRefPtr<RequestDatabaseCallback> requestCallback)
         : ExecutableWithDatabase(scriptState)
         , m_requestCallback(requestCallback) { }
     RefPtr<RequestDatabaseCallback> m_requestCallback;
 };
 
-static IDBKey* idbKeyFromInspectorObject(PassOwnPtr<protocol::IndexedDB::Key> key)
+static IDBKey* idbKeyFromInspectorObject(protocol::IndexedDB::Key* key)
 {
     IDBKey* idbKey;
 
-    if (!key || !key->hasType())
+    if (!key)
         return nullptr;
     String type = key->getType();
 
     DEFINE_STATIC_LOCAL(String, s_number, ("number"));
     DEFINE_STATIC_LOCAL(String, s_string, ("string"));
     DEFINE_STATIC_LOCAL(String, s_date, ("date"));
     DEFINE_STATIC_LOCAL(String, s_array, ("array"));
 
     if (type == s_number) {
         if (!key->hasNumber())
@@ skipping 23 matching lines @@
 static IDBKeyRange* idbKeyRangeFromKeyRange(protocol::IndexedDB::KeyRange* keyRange)
 {
     IDBKey* idbLower = idbKeyFromInspectorObject(keyRange->getLower(nullptr));
     if (keyRange->hasLower() && !idbLower)
         return nullptr;
 
     IDBKey* idbUpper = idbKeyFromInspectorObject(keyRange->getUpper(nullptr));
     if (keyRange->hasUpper() && !idbUpper)
         return nullptr;
 
-    if (!keyRange->hasLowerOpen())
-        return nullptr;
     IDBKeyRange::LowerBoundType lowerBoundType = keyRange->getLowerOpen() ? IDBKeyRange::LowerBoundOpen : IDBKeyRange::LowerBoundClosed;
-
-    if (!keyRange->hasUpperOpen())
-        return nullptr;
     IDBKeyRange::UpperBoundType upperBoundType = keyRange->getUpperOpen() ? IDBKeyRange::UpperBoundOpen : IDBKeyRange::UpperBoundClosed;
-
     return IDBKeyRange::create(idbLower, idbUpper, lowerBoundType, upperBoundType);
 }
 
 class DataLoader;
 
 class OpenCursorCallback final : public EventListener {
 public:
     static PassRefPtrWillBeRawPtr<OpenCursorCallback> create(ScriptState* scriptState, PassRefPtr<RequestDataCallback> requestCallback, int skipCount, unsigned pageSize)
     {
         return adoptRefWillBeNoop(new OpenCursorCallback(scriptState, requestCallback, skipCount, pageSize));
@@ skipping 401 matching lines @@
     clearObjectStore->start(idbFactory, document->securityOrigin(), databaseName);
 }
 
 DEFINE_TRACE(InspectorIndexedDBAgent)
 {
     visitor->trace(m_inspectedFrames);
     InspectorBaseAgent::trace(visitor);
 }
 
 } // namespace blink