DevTools: validate protocol input parameters.

third_party/WebKit/Source/platform/v8_inspector/V8DebuggerAgentImpl.cpp

 // Copyright 2015 The Chromium Authors. All rights reserved.
 // Use of this source code is governed by a BSD-style license that can be
 // found in the LICENSE file.
 
 #include "platform/v8_inspector/V8DebuggerAgentImpl.h"
 
 #include "platform/JSONValues.h"
 #include "platform/v8_inspector/AsyncCallChain.h"
 #include "platform/v8_inspector/IgnoreExceptionsScope.h"
 #include "platform/v8_inspector/InjectedScript.h"
@@ skipping 344 matching lines @@
         OwnPtr<protocol::Debugger::Location> location = resolveBreakpoint(breakpointId, script.key, breakpoint, UserBreakpointSource);
         if (location)
             (*locations)->addItem(location.release());
     }
 
     *outBreakpointId = breakpointId;
 }
 
 static bool parseLocation(ErrorString* errorString, PassOwnPtr<protocol::Debugger::Location> location, String* scriptId, int* lineNumber, int* columnNumber)
 {
-    if (!location->hasScriptId() || !location->hasLineNumber()) {
-        // FIXME: replace with input validation.
-        *errorString = "scriptId and lineNumber are required.";
-        return false;
-    }
     *scriptId = location->getScriptId();
     *lineNumber = location->getLineNumber();
     *columnNumber = location->getColumnNumber(0);
     return true;
 }
 
 void V8DebuggerAgentImpl::setBreakpoint(ErrorString* errorString,
     PassOwnPtr<protocol::Debugger::Location> location,
     const Maybe<String>& optionalCondition,
     BreakpointId* outBreakpointId,
@@ skipping 880 matching lines @@
         return;
     }
 
     if (!inPositions->length()) {
         m_blackboxedPositions.remove(scriptId);
         return;
     }
 
     Vector<std::pair<int, int>> positions(inPositions->length());
     for (size_t i = 0; i < positions.size(); ++i) {
-        OwnPtr<protocol::Debugger::ScriptPosition> position = inPositions->get(i);
-        if (!position->hasLine() || position->getLine() < 0) {
+        protocol::Debugger::ScriptPosition* position = inPositions->get(i);
+        if (position->getLine() < 0) {
             *error = "Position missing 'line' or 'line' < 0.";
             return;
         }
-        if (!position->hasColumn() || position->getColumn() < 0) {
+        if (position->getColumn() < 0) {
             *error = "Position missing 'column' or 'column' < 0.";
             return;
         }
         positions[i] = std::make_pair(position->getLine(), position->getColumn());
     }
 
     for (size_t i = 1; i < positions.size(); ++i) {
         if (positions[i - 1].first < positions[i].first)
             continue;
         if (positions[i - 1].first == positions[i].first && positions[i - 1].second < positions[i].second)
@@ skipping 214 matching lines @@
     ASSERT(m_pausedContext.IsEmpty());
     m_pausedContext.Reset(m_isolate, context);
     m_currentCallStack.Reset(m_isolate, callFrames);
     v8::HandleScope handles(m_isolate);
 
     if (!exception.IsEmpty()) {
         InjectedScript* injectedScript = m_injectedScriptManager->injectedScriptFor(context);
         if (injectedScript) {
             m_breakReason = isPromiseRejection ? protocol::Debugger::Paused::ReasonEnum::PromiseRejection : protocol::Debugger::Paused::ReasonEnum::Exception;
             auto obj = injectedScript->wrapObject(exception, V8DebuggerAgentImpl::backtraceObjectGroup);
-            m_breakAuxData = obj ? obj->asValue() : nullptr;
+            m_breakAuxData = obj ? obj->serialize() : nullptr;
             // m_breakAuxData might be null after this.
         }
     } else if (m_pausingOnAsyncOperation) {
         m_breakReason = protocol::Debugger::Paused::ReasonEnum::AsyncOperation;
         m_breakAuxData = JSONObject::create();
         m_breakAuxData->setNumber("operationId", m_currentAsyncOperationId);
     }
 
     OwnPtr<Array<String>> hitBreakpointIds = Array<String>::create();
 
@@ skipping 102 matching lines @@
     m_scripts.clear();
     m_blackboxedPositions.clear();
     m_breakpointIdToDebuggerBreakpointIds.clear();
     resetAsyncCallTracker();
     m_promiseTracker->clear();
     if (m_frontend)
         m_frontend->globalObjectCleared();
 }
 
 } // namespace blink