third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp - Issue 1739613002: DevTools: validate protocol input parameters.

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp

Issue 1739613002: DevTools: validate protocol input parameters. (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: rebaselined a test. Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « third_party/WebKit/Source/modules/indexeddb/InspectorIndexedDBAgent.cpp ('k') | third_party/WebKit/Source/platform/inspector_protocol/CodeGenerator.py » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp

diff --git a/third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp b/third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp

index 5c6d22da8d0bc85677eac8fd289660a6933c3946..1d8740913f7eb307fa82a7f92b5b1751807bc58c 100644

--- a/third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp

+++ b/third_party/WebKit/Source/modules/storage/InspectorDOMStorageAgent.cpp

@@ -193,12 +193,6 @@ void InspectorDOMStorageAgent::didDispatchDOMStorageEvent(const String& key, con

StorageArea* InspectorDOMStorageAgent::findStorageArea(ErrorString* errorString, PassOwnPtr<protocol::DOMStorage::StorageId> storageId, LocalFrame*& targetFrame)

{

- if (!storageId->hasSecurityOrigin() || !storageId->hasIsLocalStorage()) {

- if (errorString)

- *errorString = "Invalid storageId format";

- return nullptr;

- }

String securityOrigin = storageId->getSecurityOrigin();

bool isLocalStorage = storageId->getIsLocalStorage();