Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(695)

Issues Search
    My Issues | Starred     Open | Closed | All

Issue 1729723003: Reland: Remove DialogDelegate::OnClosed() which is redundant with (Closed)

Created:
4 years, 10 months ago by Evan Stade
Modified:
4 years, 10 months ago
Reviewers:
Avi (use Gerrit), sky
CC:
chromium-reviews, tim+watch_chromium.org, extensions-reviews_chromium.org, sadrul, vabr+watchlistpasswordmanager_chromium.org, zea+watch_chromium.org, tfarina, maxbogue+watch_chromium.org, plaree+watch_chromium.org, oshima+watch_chromium.org, chromium-apps-reviews_chromium.org, kalyank, gcasto+watchlist_chromium.org, davemoore+watch_chromium.org, mkwst+watchlist-passwords_chromium.org
Base URL:
https://chromium.googlesource.com/chromium/src.git@master
Target Ref:
refs/pending/heads/master
Project:
chromium
Visibility:
Public.

Description

Reland: Remove DialogDelegate::OnClosed() which is redundant with WidgetDelegate::WindowClosing(). ... with fix for use-after-free in LogoutConfirmationController BUG=585312, 583330 Original Review URL: https://codereview.chromium.org/1686433002 Committed: https://crrev.com/cac80a14f7d1e275e985c70b8b734c094bea5b76 Cr-Commit-Position: refs/heads/master@{#377400}

Patch Set 1 #

Patch Set 2 : with fix #

Unified diffs Side-by-side diffs Delta from patch set Stats (+113 lines, -132 lines) Patch
M ash/system/chromeos/session/logout_confirmation_controller.cc View 1 1 chunk +1 line, -1 line 0 comments Download
M ash/system/chromeos/session/logout_confirmation_dialog.h View 1 1 chunk +4 lines, -2 lines 0 comments Download
M ash/system/chromeos/session/logout_confirmation_dialog.cc View 1 2 chunks +8 lines, -6 lines 0 comments Download
M chrome/browser/chromeos/enrollment_dialog_view.cc View 3 chunks +11 lines, -12 lines 0 comments Download
M chrome/browser/ui/views/extensions/extension_install_dialog_view_browsertest.cc View 4 chunks +26 lines, -31 lines 0 comments Download
M chrome/browser/ui/views/first_run_dialog.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/first_run_dialog.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/passwords/account_chooser_dialog_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/passwords/account_chooser_dialog_view.cc View 2 chunks +5 lines, -5 lines 0 comments Download
M chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.h View 1 chunk +1 line, -1 line 0 comments Download
M chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc View 1 chunk +5 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/passwords/password_dialog_view_browsertest.cc View 6 chunks +4 lines, -7 lines 0 comments Download
M chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.h View 1 chunk +3 lines, -1 line 0 comments Download
M chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc View 2 chunks +4 lines, -4 lines 0 comments Download
M components/app_modal/views/javascript_app_modal_dialog_views.h View 1 chunk +1 line, -1 line 0 comments Download
M components/app_modal/views/javascript_app_modal_dialog_views.cc View 2 chunks +12 lines, -12 lines 0 comments Download
M ui/views/window/dialog_client_view.h View 2 chunks +2 lines, -5 lines 0 comments Download
M ui/views/window/dialog_client_view.cc View 5 chunks +17 lines, -27 lines 0 comments Download
M ui/views/window/dialog_delegate.h View 1 chunk +0 lines, -3 lines 0 comments Download

Messages

Total messages: 13 (5 generated)
Evan Stade
PS1 is the original change. PS2 adds the fix for the use-after-free. I was able ...
4 years, 10 months ago (2016-02-24 01:07:27 UTC) #2
commit-bot: I haz the power
Dry run: CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729723003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729723003/20001
4 years, 10 months ago (2016-02-24 01:12:50 UTC) #4
commit-bot: I haz the power
Dry run: This issue passed the CQ dry run.
4 years, 10 months ago (2016-02-24 03:08:22 UTC) #6
sky
LGTM
4 years, 10 months ago (2016-02-24 17:15:04 UTC) #7
Avi (use Gerrit)
still LGTM
4 years, 10 months ago (2016-02-24 17:19:46 UTC) #8
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-cq-status.appspot.com/patch-status/1729723003/20001 View timeline at https://chromium-cq-status.appspot.com/patch-timeline/1729723003/20001
4 years, 10 months ago (2016-02-24 22:03:09 UTC) #10
commit-bot: I haz the power
Committed patchset #2 (id:20001)
4 years, 10 months ago (2016-02-24 22:12:29 UTC) #11
commit-bot: I haz the power
4 years, 10 months ago (2016-02-24 22:14:24 UTC) #13
Message was sent while issue was closed. 
Patchset 2 (id:??) landed as
https://crrev.com/cac80a14f7d1e275e985c70b8b734c094bea5b76
Cr-Commit-Position: refs/heads/master@{#377400}

Powered by Google App Engine
This is Rietveld 408576698