components/app_modal/views/javascript_app_modal_dialog_views.h - Issue 1729723003: Reland: Remove DialogDelegate::OnClosed() which is redundant with

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: components/app_modal/views/javascript_app_modal_dialog_views.h

Issue 1729723003: Reland: Remove DialogDelegate::OnClosed() which is redundant with (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: with fix Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « chrome/browser/ui/views/sync/profile_signin_confirmation_dialog_views.cc ('k') | components/app_modal/views/javascript_app_modal_dialog_views.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: components/app_modal/views/javascript_app_modal_dialog_views.h

diff --git a/components/app_modal/views/javascript_app_modal_dialog_views.h b/components/app_modal/views/javascript_app_modal_dialog_views.h

index 32d6daa6d55857439bd8169dba4e250ef4046c3e..8ca0bbfd4fdd08973ee9080a1b3069a330c7afd6 100644

--- a/components/app_modal/views/javascript_app_modal_dialog_views.h

+++ b/components/app_modal/views/javascript_app_modal_dialog_views.h

@@ -46,7 +46,7 @@ class JavaScriptAppModalDialogViews : public NativeAppModalDialog,

ui::ModalType GetModalType() const override;

views::View* GetContentsView() override;

views::View* GetInitiallyFocusedView() override;

- void OnClosed() override;

+ void WindowClosing() override;

views::Widget* GetWidget() override;

const views::Widget* GetWidget() const override;