ash/system/chromeos/session/logout_confirmation_dialog.h - Issue 1729723003: Reland: Remove DialogDelegate::OnClosed() which is redundant with

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/chromeos/session/logout_confirmation_dialog.h

Issue 1729723003: Reland: Remove DialogDelegate::OnClosed() which is redundant with (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: with fix Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

« no previous file with comments | « ash/system/chromeos/session/logout_confirmation_controller.cc ('k') | ash/system/chromeos/session/logout_confirmation_dialog.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Hide Comments ('s')

Index: ash/system/chromeos/session/logout_confirmation_dialog.h

diff --git a/ash/system/chromeos/session/logout_confirmation_dialog.h b/ash/system/chromeos/session/logout_confirmation_dialog.h

index 61407b10fa307b412e52daf1773379f78ad3b19a..d9d2c3d39b0afce235072473cf245864eaf98f03 100644

--- a/ash/system/chromeos/session/logout_confirmation_dialog.h

+++ b/ash/system/chromeos/session/logout_confirmation_dialog.h

@@ -30,13 +30,15 @@ class LogoutConfirmationDialog : public views::DialogDelegateView {

void Update(base::TimeTicks logout_time);

+ // Called when |controller_| is no longer valid.

+ void ControllerGone();

// views::DialogDelegateView:

bool Accept() override;

ui::ModalType GetModalType() const override;

base::string16 GetWindowTitle() const override;

base::string16 GetDialogButtonLabel(ui::DialogButton button) const override;

- void OnClosed() override;

- void DeleteDelegate() override;

+ void WindowClosing() override;

private:

void UpdateLabel();