ash/system/chromeos/session/logout_confirmation_controller.cc - Issue 1729723003: Reland: Remove DialogDelegate::OnClosed() which is redundant with

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: ash/system/chromeos/session/logout_confirmation_controller.cc

Issue 1729723003: Reland: Remove DialogDelegate::OnClosed() which is redundant with (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: with fix Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

View side-by-side diff with in-line comments

Download patch

Index: ash/system/chromeos/session/logout_confirmation_controller.cc

diff --git a/ash/system/chromeos/session/logout_confirmation_controller.cc b/ash/system/chromeos/session/logout_confirmation_controller.cc

index 970903d5c01ac6345ed0e17aadf4c3ebb009b973..7c724b07da5d964444e4ab052e2e09d9dfb34915 100644

--- a/ash/system/chromeos/session/logout_confirmation_controller.cc

+++ b/ash/system/chromeos/session/logout_confirmation_controller.cc

@@ -30,7 +30,7 @@ LogoutConfirmationController::~LogoutConfirmationController() {

if (Shell::HasInstance())

Shell::GetInstance()->RemoveShellObserver(this);

if (dialog_)

- dialog_->GetWidget()->Close();

+ dialog_->ControllerGone();

}

void LogoutConfirmationController::ConfirmLogout(

« no previous file with comments | « no previous file | ash/system/chromeos/session/logout_confirmation_dialog.h » ('j') | no next file with comments »