Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(1095)

Unified Diff: chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc

Issue 1729723003: Reland: Remove DialogDelegate::OnClosed() which is redundant with (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: with fix Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
Index: chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc
diff --git a/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc b/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc
index 6af5aadf2c9296aba932ef796ce7dda87f64e566..a25667ceab1763331cec31fa460021226fd5c66b 100644
--- a/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc
+++ b/chrome/browser/ui/views/passwords/auto_signin_first_run_dialog_view.cc
@@ -105,19 +105,17 @@ views::View* AutoSigninFirstRunDialogView::GetInitiallyFocusedView() {
return ok_button_;
}
+void AutoSigninFirstRunDialogView::WindowClosing() {
+ if (controller_)
+ controller_->OnCloseDialog();
+}
+
int AutoSigninFirstRunDialogView::GetDialogButtons() const {
// None because ESC is equivalent to Cancel. It shouldn't turn off the auto
// signin.
return ui::DIALOG_BUTTON_NONE;
}
-void AutoSigninFirstRunDialogView::OnClosed() {
- if (controller_)
- controller_->OnCloseDialog();
- // This method is called twice. crbug.com/583330
- controller_ = nullptr;
-}
-
gfx::Size AutoSigninFirstRunDialogView::GetPreferredSize() const {
return gfx::Size(kDesiredWidth, GetHeightForWidth(kDesiredWidth));
}

Powered by Google App Engine
This is Rietveld 408576698