Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(339)

Side by Side Diff: chrome/browser/ui/views/first_run_dialog.h

Issue 1729723003: Reland: Remove DialogDelegate::OnClosed() which is redundant with (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: with fix Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch
OLDNEW
1 // Copyright 2014 The Chromium Authors. All rights reserved. 1 // Copyright 2014 The Chromium Authors. All rights reserved.
2 // Use of this source code is governed by a BSD-style license that can be 2 // Use of this source code is governed by a BSD-style license that can be
3 // found in the LICENSE file. 3 // found in the LICENSE file.
4 4
5 #ifndef CHROME_BROWSER_UI_VIEWS_FIRST_RUN_DIALOG_H_ 5 #ifndef CHROME_BROWSER_UI_VIEWS_FIRST_RUN_DIALOG_H_
6 #define CHROME_BROWSER_UI_VIEWS_FIRST_RUN_DIALOG_H_ 6 #define CHROME_BROWSER_UI_VIEWS_FIRST_RUN_DIALOG_H_
7 7
8 #include "base/callback.h" 8 #include "base/callback.h"
9 #include "base/macros.h" 9 #include "base/macros.h"
10 #include "ui/views/controls/link_listener.h" 10 #include "ui/views/controls/link_listener.h"
(...skipping 15 matching lines...) Expand all
26 26
27 private: 27 private:
28 explicit FirstRunDialog(Profile* profile); 28 explicit FirstRunDialog(Profile* profile);
29 ~FirstRunDialog() override; 29 ~FirstRunDialog() override;
30 30
31 // This terminates the nested message-loop. 31 // This terminates the nested message-loop.
32 void Done(); 32 void Done();
33 33
34 // views::DialogDelegate: 34 // views::DialogDelegate:
35 views::View* CreateExtraView() override; 35 views::View* CreateExtraView() override;
36 void OnClosed() override;
37 bool Accept() override; 36 bool Accept() override;
38 int GetDialogButtons() const override; 37 int GetDialogButtons() const override;
39 38
39 // views::WidgetDelegate:
40 void WindowClosing() override;
41
40 // views::LinkListener: 42 // views::LinkListener:
41 void LinkClicked(views::Link* source, int event_flags) override; 43 void LinkClicked(views::Link* source, int event_flags) override;
42 44
43 Profile* profile_; 45 Profile* profile_;
44 views::Checkbox* make_default_; 46 views::Checkbox* make_default_;
45 views::Checkbox* report_crashes_; 47 views::Checkbox* report_crashes_;
46 base::Closure quit_runloop_; 48 base::Closure quit_runloop_;
47 49
48 DISALLOW_COPY_AND_ASSIGN(FirstRunDialog); 50 DISALLOW_COPY_AND_ASSIGN(FirstRunDialog);
49 }; 51 };
50 52
51 #endif // CHROME_BROWSER_UI_VIEWS_FIRST_RUN_DIALOG_H_ 53 #endif // CHROME_BROWSER_UI_VIEWS_FIRST_RUN_DIALOG_H_
OLDNEW

Powered by Google App Engine
This is Rietveld 408576698