Enable concurrent sweep on MIPS and ARM64.

Enable concurrent sweep on MIPS and ARM64.

Compare ARM from commit f78517a5ba83d61838690f0d4efb6ec3b3c9521e.

Closes #25651.

R=zra@google.com

Committed: https://github.com/dart-lang/sdk/commit/cb210e39978f3785dcb56aaf4b14f26521b73caa

[rmacnak, 2016-02-23 17:46:10]

Description was changed from

==========
Enable concurrent sweep on MIPS and ARM64.

BUG=
==========

to

==========
Enable concurrent sweep on MIPS and ARM64.

Compare ARM from commit f78517a5ba83d61838690f0d4efb6ec3b3c9521e.

Closes #25651.
==========

[rmacnak, 2016-02-25 00:18:52]

rmacnak@google.com changed reviewers:
+ iposva@google.com, zra@google.com

[rmacnak, 2016-02-25 00:18:52]

(2-core)
rmacnak@ci20-2585:~$ ./dart1/sdk/out/ReleaseMIPS/dart --concurrent-sweep=false
./benchmarks/Splay/dart/Splay.dart Splay(RunTime): 21329.898914893616 us.
rmacnak@ci20-2585:~$ ./dart1/sdk/out/ReleaseMIPS/dart --concurrent-sweep=true
./benchmarks/Splay/dart/Splay.dart 
Splay(RunTime): 21088.784663157898 us.
rmacnak@ci20-2585:~$ ./dart1/sdk/out/ReleaseMIPS/dart --concurrent-sweep=false
./benchmarks/SplayHarder/dart/SplayHarder.dart 
SplayHarder(RunTime): 210524.86000000002 us.
rmacnak@ci20-2585:~$ ./dart1/sdk/out/ReleaseMIPS/dart --concurrent-sweep=true
./benchmarks/SplayHarder/dart/SplayHarder.dart 
SplayHarder(RunTime): 179246.85231578947 us.

(4-core)
rmacnak@dragon:~$ ./dart1/sdk/out/ReleaseARM64/dart --concurrent-sweep=false
./benchmarks/Splay/dart/Splay.dart
Splay(RunTime): 13450.525664429528 us.
rmacnak@dragon:~$ ./dart1/sdk/out/ReleaseARM64/dart --concurrent-sweep=true
./benchmarks/Splay/dart/Splay.dart
Splay(RunTime): 13767.335080246912 us.
rmacnak@dragon:~$ ./dart1/sdk/out/ReleaseARM64/dart --concurrent-sweep=false
./benchmarks/SplayHarder/dart/SplayHarder.dart
SplayHarder(RunTime): 85140.1878 us.
rmacnak@dragon:~$ ./dart1/sdk/out/ReleaseARM64/dart --concurrent-sweep=true
./benchmarks/SplayHarder/dart/SplayHarder.dart
SplayHarder(RunTime): 64851.03393548387 us.

[zra, 2016-02-25 04:02:35]

Nice.

Please add assembler tests for the new instructions.

https://codereview.chromium.org/1722013002/diff/40001/runtime/vm/assembler_ar...
File runtime/vm/assembler_arm64.h (right):

https://codereview.chromium.org/1722013002/diff/40001/runtime/vm/assembler_ar...
runtime/vm/assembler_arm64.h:760: void ldxr(Register rt, Register rn) {
As on ARM, clrex looks like it would be useful to add as well, for testing.

https://codereview.chromium.org/1722013002/diff/40001/runtime/vm/assembler_mi...
File runtime/vm/assembler_mips.h (right):

https://codereview.chromium.org/1722013002/diff/40001/runtime/vm/assembler_mi...
runtime/vm/assembler_mips.h:803: // rt = 1 on success, 0 on failure
End comment with '.'

https://codereview.chromium.org/1722013002/diff/40001/runtime/vm/simulator_ar...
File runtime/vm/simulator_arm64.cc (right):

https://codereview.chromium.org/1722013002/diff/40001/runtime/vm/simulator_ar...
runtime/vm/simulator_arm64.cc:1226: intptr_t Simulator::ReadExclusiveW(uword
addr, Instr* instr) {
Hmm. Should this be int32_t? ReadW returns int32_t. I thought you were
implementing the 64-bit version only, so this would have to be ReadExclusiveX
which calls ReadX, I think.

https://codereview.chromium.org/1722013002/diff/40001/runtime/vm/simulator_ar...
runtime/vm/simulator_arm64.cc:2185: intptr_t value = ReadExclusiveW(addr,
instr);
int64_t calling ReadExclusiveX?

[rmacnak, 2016-02-25 23:31:46]

ported the arm assembler tests

https://codereview.chromium.org/1722013002/diff/40001/runtime/vm/assembler_ar...
File runtime/vm/assembler_arm64.h (right):

https://codereview.chromium.org/1722013002/diff/40001/runtime/vm/assembler_ar...
runtime/vm/assembler_arm64.h:760: void ldxr(Register rt, Register rn) {
On 2016/02/25 04:02:35, zra wrote:
> As on ARM, clrex looks like it would be useful to add as well, for testing.

Done.

https://codereview.chromium.org/1722013002/diff/40001/runtime/vm/assembler_mi...
File runtime/vm/assembler_mips.h (right):

https://codereview.chromium.org/1722013002/diff/40001/runtime/vm/assembler_mi...
runtime/vm/assembler_mips.h:803: // rt = 1 on success, 0 on failure
On 2016/02/25 04:02:35, zra wrote:
> End comment with '.'

Done.

https://codereview.chromium.org/1722013002/diff/40001/runtime/vm/simulator_ar...
File runtime/vm/simulator_arm64.cc (right):

https://codereview.chromium.org/1722013002/diff/40001/runtime/vm/simulator_ar...
runtime/vm/simulator_arm64.cc:1226: intptr_t Simulator::ReadExclusiveW(uword
addr, Instr* instr) {
On 2016/02/25 04:02:35, zra wrote:
> Hmm. Should this be int32_t? ReadW returns int32_t. I thought you were
> implementing the 64-bit version only, so this would have to be ReadExclusiveX
> which calls ReadX, I think.

Changed this to ReadExclusiveX using ReadX.

https://codereview.chromium.org/1722013002/diff/40001/runtime/vm/simulator_ar...
runtime/vm/simulator_arm64.cc:2185: intptr_t value = ReadExclusiveW(addr,
instr);
On 2016/02/25 04:02:35, zra wrote:
> int64_t calling ReadExclusiveX?

Done.

[zra, 2016-02-25 23:40:35]

lgtm

[rmacnak, 2016-02-29 17:23:29]

Description was changed from

==========
Enable concurrent sweep on MIPS and ARM64.

Compare ARM from commit f78517a5ba83d61838690f0d4efb6ec3b3c9521e.

Closes #25651.
==========

to

==========
Enable concurrent sweep on MIPS and ARM64.

Compare ARM from commit f78517a5ba83d61838690f0d4efb6ec3b3c9521e.

Closes #25651.

R=zra@google.com

Committed:
https://github.com/dart-lang/sdk/commit/cb210e39978f3785dcb56aaf4b14f26521b73caa
==========

[rmacnak, 2016-02-29 17:23:30]

Committed patchset #4 (id:60001) manually as
cb210e39978f3785dcb56aaf4b14f26521b73caa (presubmit successful).