base: Stop overloading ReadFileToString()

base: Stop overloading ReadFileToString()

With the existing code, base::Bind(&base::ReadFileToString) doesn't compile because
the compiler cannot infer the argument's type (2-argument version or
3-argument version).
base::Bind<bool(*)(const base::FilePath&,
std::string*)>(&base::ReadFileToString) compiles but it doesn't look
desirable.

As our style guide discourages function overloading(*), rename the 3-argument version (added in http://crrev.com/157593005) to stop overloading.

*https://google.github.io/styleguide/cppguide.html#Function_Overloading

BUG=None
TBR=sgurun@chromium.org for android_webview, derat@chromium.org for chromeos/accelerometer, bartfab@chromium.org for components/policy, dsinclair@chromium.org for components/tracing, estade@chromium.org for content/browser/webui, sergeyu@chromium.org for remoting

Committed: https://crrev.com/6da2fef05a6d503710e5f9b6f1363d94eac7c633
Cr-Commit-Position: refs/heads/master@{#377209}

[hashimoto, 2016-02-23 09:09:07]

Description was changed from

==========
base: Stop overloading ReadFileToString()

With the existing code, base::Bind(&base::ReadFileToString) doesn't compile
because
the compiler cannot infer the argument's type (2-argument version or
3-argument version).
base::Bind<void(*)(const base::FilePath&,
std::string*)>(&base::ReadFileToString) compiles but it doesn't look
desirable.

Rename the 3-argument version to stop overloading.

BUG=None
==========

to

==========
base: Stop overloading ReadFileToString()

With the existing code, base::Bind(&base::ReadFileToString) doesn't compile
because
the compiler cannot infer the argument's type (2-argument version or
3-argument version).
base::Bind<void(*)(const base::FilePath&,
std::string*)>(&base::ReadFileToString) compiles but it doesn't look
desirable.

Rename the 3-argument version (added in http://crrev.com/157593005) to stop
overloading.

BUG=None
==========

[hashimoto, 2016-02-23 09:32:38]

Description was changed from

==========
base: Stop overloading ReadFileToString()

With the existing code, base::Bind(&base::ReadFileToString) doesn't compile
because
the compiler cannot infer the argument's type (2-argument version or
3-argument version).
base::Bind<void(*)(const base::FilePath&,
std::string*)>(&base::ReadFileToString) compiles but it doesn't look
desirable.

Rename the 3-argument version (added in http://crrev.com/157593005) to stop
overloading.

BUG=None
==========

to

==========
base: Stop overloading ReadFileToString()

With the existing code, base::Bind(&base::ReadFileToString) doesn't compile
because
the compiler cannot infer the argument's type (2-argument version or
3-argument version).
base::Bind<void(*)(const base::FilePath&,
std::string*)>(&base::ReadFileToString) compiles but it doesn't look
desirable.

As our style guide discourages function overloading (*), rename the 3-argument
version (added in http://crrev.com/157593005) to stop overloading.

*https://google.github.io/styleguide/cppguide.html#Function_Overloading

BUG=None
==========

[hashimoto, 2016-02-23 09:40:16]

Description was changed from

==========
base: Stop overloading ReadFileToString()

With the existing code, base::Bind(&base::ReadFileToString) doesn't compile
because
the compiler cannot infer the argument's type (2-argument version or
3-argument version).
base::Bind<void(*)(const base::FilePath&,
std::string*)>(&base::ReadFileToString) compiles but it doesn't look
desirable.

As our style guide discourages function overloading (*), rename the 3-argument
version (added in http://crrev.com/157593005) to stop overloading.

*https://google.github.io/styleguide/cppguide.html#Function_Overloading

BUG=None
==========

to

==========
base: Stop overloading ReadFileToString()

With the existing code, base::Bind(&base::ReadFileToString) doesn't compile
because
the compiler cannot infer the argument's type (2-argument version or
3-argument version).
base::Bind<bool(*)(const base::FilePath&,
std::string*)>(&base::ReadFileToString) compiles but it doesn't look
desirable.

As our style guide discourages function overloading (*), rename the 3-argument
version (added in http://crrev.com/157593005) to stop overloading.

*https://google.github.io/styleguide/cppguide.html#Function_Overloading

BUG=None
==========

[hashimoto, 2016-02-23 09:40:35]

Description was changed from

==========
base: Stop overloading ReadFileToString()

With the existing code, base::Bind(&base::ReadFileToString) doesn't compile
because
the compiler cannot infer the argument's type (2-argument version or
3-argument version).
base::Bind<bool(*)(const base::FilePath&,
std::string*)>(&base::ReadFileToString) compiles but it doesn't look
desirable.

As our style guide discourages function overloading (*), rename the 3-argument
version (added in http://crrev.com/157593005) to stop overloading.

*https://google.github.io/styleguide/cppguide.html#Function_Overloading

BUG=None
==========

to

==========
base: Stop overloading ReadFileToString()

With the existing code, base::Bind(&base::ReadFileToString) doesn't compile
because
the compiler cannot infer the argument's type (2-argument version or
3-argument version).
base::Bind<bool(*)(const base::FilePath&,
std::string*)>(&base::ReadFileToString) compiles but it doesn't look
desirable.

As our style guide discourages function overloading(*), rename the 3-argument
version (added in http://crrev.com/157593005) to stop overloading.

*https://google.github.io/styleguide/cppguide.html#Function_Overloading

BUG=None
==========

[hashimoto, 2016-02-23 10:26:31]

hashimoto@chromium.org changed reviewers:
+ thestig@chromium.org

[Lei Zhang, 2016-02-23 21:16:27]

lgtm

[hashimoto, 2016-02-24 02:24:10]

Description was changed from

==========
base: Stop overloading ReadFileToString()

With the existing code, base::Bind(&base::ReadFileToString) doesn't compile
because
the compiler cannot infer the argument's type (2-argument version or
3-argument version).
base::Bind<bool(*)(const base::FilePath&,
std::string*)>(&base::ReadFileToString) compiles but it doesn't look
desirable.

As our style guide discourages function overloading(*), rename the 3-argument
version (added in http://crrev.com/157593005) to stop overloading.

*https://google.github.io/styleguide/cppguide.html#Function_Overloading

BUG=None
==========

to

==========
base: Stop overloading ReadFileToString()

With the existing code, base::Bind(&base::ReadFileToString) doesn't compile
because
the compiler cannot infer the argument's type (2-argument version or
3-argument version).
base::Bind<bool(*)(const base::FilePath&,
std::string*)>(&base::ReadFileToString) compiles but it doesn't look
desirable.

As our style guide discourages function overloading(*), rename the 3-argument
version (added in http://crrev.com/157593005) to stop overloading.

*https://google.github.io/styleguide/cppguide.html#Function_Overloading

BUG=None
TBR=sgurun@chromium.org for android_webview, derat@chromium.org for
chromeos/accelerometer, bartfab@chromium.org for components/policy,
dsinclair@chromium.org for components/tracing, estade@chromium.org for
content/browser/webui, sergeyu@chromium.org for remoting
==========

[hashimoto, 2016-02-24 02:25:39]

hashimoto@chromium.org changed reviewers:
+ bartfab@chromium.org, derat@chromium.org, dsinclair@chromium.org,
estade@chromium.org, sergeyu@chromium.org, sgurun@chromium.org

[hashimoto, 2016-02-24 02:25:39]

TBRing following people:
- sgurun@chromium.org for android_webview
- derat@chromium.org for chromeos/accelerometer
- bartfab@chromium.org for components/policy
- dsinclair@chromium.org for components/tracing
- estade@chromium.org for content/browser/webui
- sergeyu@chromium.org for remoting

[hashimoto, 2016-02-24 03:25:11]

The CQ bit was checked by hashimoto@chromium.org

[commit-bot: I haz the power, 2016-02-24 03:28:16]

CQ is trying da patch. Follow status at
 https://chromium-cq-status.appspot.com/patch-status/1719983005/20001
View timeline at
 https://chromium-cq-status.appspot.com/patch-timeline/1719983005/20001

[commit-bot: I haz the power, 2016-02-24 03:40:06]

Description was changed from

==========
base: Stop overloading ReadFileToString()

With the existing code, base::Bind(&base::ReadFileToString) doesn't compile
because
the compiler cannot infer the argument's type (2-argument version or
3-argument version).
base::Bind<bool(*)(const base::FilePath&,
std::string*)>(&base::ReadFileToString) compiles but it doesn't look
desirable.

As our style guide discourages function overloading(*), rename the 3-argument
version (added in http://crrev.com/157593005) to stop overloading.

*https://google.github.io/styleguide/cppguide.html#Function_Overloading

BUG=None
TBR=sgurun@chromium.org for android_webview, derat@chromium.org for
chromeos/accelerometer, bartfab@chromium.org for components/policy,
dsinclair@chromium.org for components/tracing, estade@chromium.org for
content/browser/webui, sergeyu@chromium.org for remoting
==========

to

==========
base: Stop overloading ReadFileToString()

With the existing code, base::Bind(&base::ReadFileToString) doesn't compile
because
the compiler cannot infer the argument's type (2-argument version or
3-argument version).
base::Bind<bool(*)(const base::FilePath&,
std::string*)>(&base::ReadFileToString) compiles but it doesn't look
desirable.

As our style guide discourages function overloading(*), rename the 3-argument
version (added in http://crrev.com/157593005) to stop overloading.

*https://google.github.io/styleguide/cppguide.html#Function_Overloading

BUG=None
TBR=sgurun@chromium.org for android_webview, derat@chromium.org for
chromeos/accelerometer, bartfab@chromium.org for components/policy,
dsinclair@chromium.org for components/tracing, estade@chromium.org for
content/browser/webui, sergeyu@chromium.org for remoting
==========

[commit-bot: I haz the power, 2016-02-24 03:40:07]

Committed patchset #2 (id:20001)

[commit-bot: I haz the power, 2016-02-24 03:41:26]

Description was changed from

==========
base: Stop overloading ReadFileToString()

With the existing code, base::Bind(&base::ReadFileToString) doesn't compile
because
the compiler cannot infer the argument's type (2-argument version or
3-argument version).
base::Bind<bool(*)(const base::FilePath&,
std::string*)>(&base::ReadFileToString) compiles but it doesn't look
desirable.

As our style guide discourages function overloading(*), rename the 3-argument
version (added in http://crrev.com/157593005) to stop overloading.

*https://google.github.io/styleguide/cppguide.html#Function_Overloading

BUG=None
TBR=sgurun@chromium.org for android_webview, derat@chromium.org for
chromeos/accelerometer, bartfab@chromium.org for components/policy,
dsinclair@chromium.org for components/tracing, estade@chromium.org for
content/browser/webui, sergeyu@chromium.org for remoting
==========

to

==========
base: Stop overloading ReadFileToString()

With the existing code, base::Bind(&base::ReadFileToString) doesn't compile
because
the compiler cannot infer the argument's type (2-argument version or
3-argument version).
base::Bind<bool(*)(const base::FilePath&,
std::string*)>(&base::ReadFileToString) compiles but it doesn't look
desirable.

As our style guide discourages function overloading(*), rename the 3-argument
version (added in http://crrev.com/157593005) to stop overloading.

*https://google.github.io/styleguide/cppguide.html#Function_Overloading

BUG=None
TBR=sgurun@chromium.org for android_webview, derat@chromium.org for
chromeos/accelerometer, bartfab@chromium.org for components/policy,
dsinclair@chromium.org for components/tracing, estade@chromium.org for
content/browser/webui, sergeyu@chromium.org for remoting

Committed: https://crrev.com/6da2fef05a6d503710e5f9b6f1363d94eac7c633
Cr-Commit-Position: refs/heads/master@{#377209}
==========

[commit-bot: I haz the power, 2016-02-24 03:41:28]

Patchset 2 (id:??) landed as
https://crrev.com/6da2fef05a6d503710e5f9b6f1363d94eac7c633
Cr-Commit-Position: refs/heads/master@{#377209}

[Daniel Erat, 2016-02-24 05:28:20]

lgtm

[bartfab (slow), 2016-02-24 13:48:00]

lgtm