chromeos/accelerometer/accelerometer_reader.cc - Issue 1719983005: base: Stop overloading ReadFileToString()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chromeos/accelerometer/accelerometer_reader.cc

Issue 1719983005: base: Stop overloading ReadFileToString() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix errors Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chromeos/accelerometer/accelerometer_reader.cc

diff --git a/chromeos/accelerometer/accelerometer_reader.cc b/chromeos/accelerometer/accelerometer_reader.cc

index bf96443c22bc1febe1e68ba895c33482e9f66e84..4cc0bfd0f226e3c8e23c780bfc890cbb8317eb63 100644

--- a/chromeos/accelerometer/accelerometer_reader.cc

+++ b/chromeos/accelerometer/accelerometer_reader.cc

@@ -91,7 +91,7 @@ const int kSizeOfReading = kDataSize * kNumberOfAxes;

bool ReadFileToInt(const base::FilePath& path, int* value) {

std::string s;

DCHECK(value);

- if (!base::ReadFileToString(path, &s, kMaxAsciiUintLength)) {

+ if (!base::ReadFileToStringWithMaxSize(path, &s, kMaxAsciiUintLength)) {

return false;

}

base::TrimWhitespaceASCII(s, base::TRIM_ALL, &s);