chrome/test/ppapi/ppapi_filechooser_browsertest.cc - Issue 1719983005: base: Stop overloading ReadFileToString()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/test/ppapi/ppapi_filechooser_browsertest.cc

Issue 1719983005: base: Stop overloading ReadFileToString() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix errors Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/test/ppapi/ppapi_filechooser_browsertest.cc

diff --git a/chrome/test/ppapi/ppapi_filechooser_browsertest.cc b/chrome/test/ppapi/ppapi_filechooser_browsertest.cc

index 181d1096c9e9ccdf52c0ef44222dc7177cd087d0..74de60a8d9870a3a7cc9eee5da1c2577ec96a36e 100644

--- a/chrome/test/ppapi/ppapi_filechooser_browsertest.cc

+++ b/chrome/test/ppapi/ppapi_filechooser_browsertest.cc

@@ -239,7 +239,7 @@ IN_PROC_BROWSER_TEST_F(PPAPIFileChooserTest,

ASSERT_TRUE(base::PathExists(actual_filename));

std::string file_contents;

- ASSERT_TRUE(base::ReadFileToString(actual_filename, &file_contents, 100));

+ ASSERT_TRUE(base::ReadFileToString(actual_filename, &file_contents));

EXPECT_EQ("Hello from PPAPI", file_contents);

}

@@ -260,7 +260,7 @@ IN_PROC_BROWSER_TEST_F(PPAPIFileChooserTest,

ASSERT_TRUE(base::PathExists(actual_filename));

std::string file_contents;

- ASSERT_TRUE(base::ReadFileToString(actual_filename, &file_contents, 100));

+ ASSERT_TRUE(base::ReadFileToString(actual_filename, &file_contents));

EXPECT_EQ("Hello from PPAPI", file_contents);

}

@@ -295,7 +295,7 @@ IN_PROC_BROWSER_TEST_F(PPAPIFileChooserTest,

ASSERT_TRUE(base::PathExists(actual_filename));

std::string file_contents;

- ASSERT_TRUE(base::ReadFileToString(actual_filename, &file_contents, 100));

+ ASSERT_TRUE(base::ReadFileToString(actual_filename, &file_contents));

EXPECT_EQ("Hello from PPAPI", file_contents);

}

@@ -343,7 +343,7 @@ IN_PROC_BROWSER_TEST_F(PPAPIFileChooserTestWithSBService,

ASSERT_TRUE(base::PathExists(actual_filename));

std::string file_contents;

- ASSERT_TRUE(base::ReadFileToString(actual_filename, &file_contents, 100));

+ ASSERT_TRUE(base::ReadFileToString(actual_filename, &file_contents));

EXPECT_EQ("Hello from PPAPI", file_contents);

}