Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(2526)

Unified Diff: base/files/file_util_unittest.cc

Issue 1719983005: base: Stop overloading ReadFileToString() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master
Patch Set: Fix errors Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « base/files/file_util.cc ('k') | chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc » ('j') | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: base/files/file_util_unittest.cc
diff --git a/base/files/file_util_unittest.cc b/base/files/file_util_unittest.cc
index 61ccba4902be7ca1e3f2d2ab3163e43b30cd5652..a0d0a28927f6eae9c672fa201f30291765300369 100644
--- a/base/files/file_util_unittest.cc
+++ b/base/files/file_util_unittest.cc
@@ -2066,26 +2066,26 @@ TEST_F(FileUtilTest, ReadFileToString) {
EXPECT_EQ(kTestData, data);
data = "temp";
- EXPECT_FALSE(ReadFileToString(file_path, &data, 0));
+ EXPECT_FALSE(ReadFileToStringWithMaxSize(file_path, &data, 0));
EXPECT_EQ(0u, data.length());
data = "temp";
- EXPECT_FALSE(ReadFileToString(file_path, &data, 2));
+ EXPECT_FALSE(ReadFileToStringWithMaxSize(file_path, &data, 2));
EXPECT_EQ("01", data);
data.clear();
- EXPECT_FALSE(ReadFileToString(file_path, &data, 3));
+ EXPECT_FALSE(ReadFileToStringWithMaxSize(file_path, &data, 3));
EXPECT_EQ("012", data);
data.clear();
- EXPECT_TRUE(ReadFileToString(file_path, &data, 4));
+ EXPECT_TRUE(ReadFileToStringWithMaxSize(file_path, &data, 4));
EXPECT_EQ("0123", data);
data.clear();
- EXPECT_TRUE(ReadFileToString(file_path, &data, 6));
+ EXPECT_TRUE(ReadFileToStringWithMaxSize(file_path, &data, 6));
EXPECT_EQ("0123", data);
- EXPECT_TRUE(ReadFileToString(file_path, NULL, 6));
+ EXPECT_TRUE(ReadFileToStringWithMaxSize(file_path, NULL, 6));
EXPECT_TRUE(ReadFileToString(file_path, NULL));
@@ -2101,7 +2101,7 @@ TEST_F(FileUtilTest, ReadFileToString) {
EXPECT_EQ(0u, data.length());
data = "temp";
- EXPECT_FALSE(ReadFileToString(file_path, &data, 6));
+ EXPECT_FALSE(ReadFileToStringWithMaxSize(file_path, &data, 6));
EXPECT_EQ(0u, data.length());
}
« no previous file with comments | « base/files/file_util.cc ('k') | chrome/browser/chromeos/policy/user_cloud_policy_store_chromeos.cc » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698