chrome/browser/ui/webui/test_files_request_filter.cc - Issue 1719983005: base: Stop overloading ReadFileToString()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: chrome/browser/ui/webui/test_files_request_filter.cc

Issue 1719983005: base: Stop overloading ReadFileToString() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix errors Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: chrome/browser/ui/webui/test_files_request_filter.cc

diff --git a/chrome/browser/ui/webui/test_files_request_filter.cc b/chrome/browser/ui/webui/test_files_request_filter.cc

index 2a57b48124af0c8ef2ee258664101970079066dd..4c69de566cfd8e41df2ef246ab6fec23e48e0f42 100644

--- a/chrome/browser/ui/webui/test_files_request_filter.cc

+++ b/chrome/browser/ui/webui/test_files_request_filter.cc

@@ -26,7 +26,7 @@ bool HandleTestFileRequestCallback(

PathService::Get(chrome::DIR_TEST_DATA, &test_data_dir);

if (!base::ReadFileToString(

test_data_dir.AppendASCII("webui").AppendASCII(url_substr[1]),

- &contents, std::string::npos))

+ &contents))

return false;

base::RefCountedString* ref_contents = new base::RefCountedString();