android_webview/browser/aw_metrics_service_client.cc - Issue 1719983005: base: Stop overloading ReadFileToString()

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: android_webview/browser/aw_metrics_service_client.cc

Issue 1719983005: base: Stop overloading ReadFileToString() (Closed) Base URL: https://chromium.googlesource.com/chromium/src.git@master

Patch Set: Fix errors Created 4 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: android_webview/browser/aw_metrics_service_client.cc

diff --git a/android_webview/browser/aw_metrics_service_client.cc b/android_webview/browser/aw_metrics_service_client.cc

index 26d465f98f47e457afadf36e11a5f39db2e55bbf..68a485e19b8e95c902ff2512468ac7c0cd5d70f1 100644

--- a/android_webview/browser/aw_metrics_service_client.cc

+++ b/android_webview/browser/aw_metrics_service_client.cc

@@ -46,7 +46,7 @@ void GetOrCreateGUID(const base::FilePath guid_file_path, std::string* guid) {

DCHECK_CURRENTLY_ON(content::BrowserThread::FILE);

// Try to read an existing GUID.

- if (base::ReadFileToString(guid_file_path, guid, GUID_SIZE)) {

+ if (base::ReadFileToStringWithMaxSize(guid_file_path, guid, GUID_SIZE)) {

if (base::IsValidGUID(*guid))

return;

else

« no previous file with comments | « no previous file | base/files/file_util.h » ('j') | no next file with comments »