Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(33)

Issue 171773008: Rename childNodeCount() / childNode() methods for clarity (Closed)

Created:
6 years, 10 months ago by Inactive
Modified:
6 years, 10 months ago
Reviewers:
adamk, eseidel
CC:
blink-reviews, eae+blinkwatch, apavlov+blink_chromium.org, adamk+blink_chromium.org, aandrey+blink_chromium.org, rwlbuis, caseq+blink_chromium.org, bemjb+rendering_chromium.org, dsinclair, yurys+blink_chromium.org, dglazkov+blink, jchaffraix+rendering, devtools-reviews_chromium.org, pdr., loislo+blink_chromium.org, zoltan1, sof, lushnikov+blink_chromium.org, eustas+blink_chromium.org, paulirish+reviews_chromium.org, alph+blink_chromium.org, leviw+renderwatch, vsevik+blink_chromium.org, pfeldman+blink_chromium.org, groby+blinkspell_chromium.org
Visibility:
Public.

Description

Rename childNodeCount() / childNode() methods for clarity Rename childNodeCount() / childNode() methods for clarity and to avoid bad uses. They are now called countChildren() / traverseToChildAt() to make it clear that these are doing work and are now simpler getters. Also rename hasChildNodes() to hasChildren() for consistency. R=eseidel, adamk Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=167616

Patch Set 1 #

Patch Set 2 : Further renaming for consistency #

Unified diffs Side-by-side diffs Delta from patch set Stats (+100 lines, -100 lines) Patch
M Source/core/dom/ContainerNode.h View 1 3 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/ContainerNode.cpp View 3 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/ContainerNodeAlgorithms.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Element.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Node.h View 1 2 chunks +3 lines, -3 lines 0 comments Download
M Source/core/dom/Node.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/dom/Node.idl View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/Position.h View 1 chunk +2 lines, -2 lines 0 comments Download
M Source/core/dom/Position.cpp View 1 5 chunks +6 lines, -6 lines 0 comments Download
M Source/core/dom/PositionIterator.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/PositionIterator.cpp View 1 8 chunks +9 lines, -9 lines 0 comments Download
M Source/core/dom/Range.cpp View 7 chunks +7 lines, -7 lines 0 comments Download
M Source/core/dom/RangeBoundaryPoint.h View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/dom/shadow/ComposedTreeWalker.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/ApplyStyleCommand.cpp View 1 4 chunks +4 lines, -4 lines 0 comments Download
M Source/core/editing/BreakBlockquoteCommand.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/CompositeEditCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/DeleteSelectionCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/Editor.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/InsertParagraphSeparatorCommand.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/MarkupAccumulator.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/ReplaceSelectionCommand.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/editing/TextIterator.cpp View 1 4 chunks +9 lines, -9 lines 0 comments Download
M Source/core/editing/VisibleUnits.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/editing/htmlediting.cpp View 1 4 chunks +5 lines, -5 lines 0 comments Download
M Source/core/editing/markup.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/frame/SmartClip.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLHRElement.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLTextFormControlElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/HTMLViewSourceDocument.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/forms/TextFieldInputType.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/parser/HTMLTreeBuilder.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/shadow/MediaControlElements.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/html/track/vtt/VTTCue.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/inspector/DOMPatchSupport.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/DOMSelection.cpp View 2 chunks +2 lines, -2 lines 0 comments Download
M Source/core/page/SpatialNavigation.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderObject.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderReplaced.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/RenderTreeAsText.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/TextAutosizer.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/rendering/svg/RenderSVGResourceMasker.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGElementInstance.h View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/core/svg/SVGUseElement.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebFrameImpl.cpp View 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebNode.cpp View 1 1 chunk +1 line, -1 line 0 comments Download
M Source/web/WebPageSerializerImpl.cpp View 1 2 chunks +2 lines, -2 lines 0 comments Download

Messages

Total messages: 5 (0 generated)
Inactive
Let me know if you have better suggestions for the naming :)
6 years, 10 months ago (2014-02-20 01:41:28 UTC) #1
Inactive
Eric, any feedback? This is a follow-up based on your renaming proposal on my earlier ...
6 years, 10 months ago (2014-02-21 19:17:00 UTC) #2
eseidel
lgtm
6 years, 10 months ago (2014-02-21 21:18:38 UTC) #3
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/ch.dumez@samsung.com/171773008/40001
6 years, 10 months ago (2014-02-21 21:18:56 UTC) #4
commit-bot: I haz the power
6 years, 10 months ago (2014-02-21 23:18:05 UTC) #5
Message was sent while issue was closed.
Change committed as 167616

Powered by Google App Engine
This is Rietveld 408576698