Source/core/editing/MarkupAccumulator.cpp - Issue 171773008: Rename childNodeCount() / childNode() methods for clarity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/MarkupAccumulator.cpp

Issue 171773008: Rename childNodeCount() / childNode() methods for clarity (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Further renaming for consistency Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/MarkupAccumulator.cpp

diff --git a/Source/core/editing/MarkupAccumulator.cpp b/Source/core/editing/MarkupAccumulator.cpp

index 044e9ee3854ddeff91ec6e669ac94f926968841f..e4be09ebf947cfa3ca4ce4d09356b2f54273bdbf 100644

--- a/Source/core/editing/MarkupAccumulator.cpp

+++ b/Source/core/editing/MarkupAccumulator.cpp

@@ -506,7 +506,7 @@ bool MarkupAccumulator::shouldSelfClose(const Node& node)

{

if (node.document().isHTMLDocument())

return false;

- if (node.hasChildNodes())

+ if (node.hasChildren())

return false;

if (node.isHTMLElement() && !elementCannotHaveEndTag(node))

return false;

@@ -527,7 +527,7 @@ bool MarkupAccumulator::elementCannotHaveEndTag(const Node& node)

void MarkupAccumulator::appendEndMarkup(StringBuilder& result, const Node& node)

{

- if (!node.isElementNode() || shouldSelfClose(node) || (!node.hasChildNodes() && elementCannotHaveEndTag(node)))

+ if (!node.isElementNode() || shouldSelfClose(node) || (!node.hasChildren() && elementCannotHaveEndTag(node)))

return;

result.appendLiteral("</");