Source/core/editing/VisibleUnits.cpp - Issue 171773008: Rename childNodeCount() / childNode() methods for clarity

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Unified Diff: Source/core/editing/VisibleUnits.cpp

Issue 171773008: Rename childNodeCount() / childNode() methods for clarity (Closed) Base URL: svn://svn.chromium.org/blink/trunk

Patch Set: Further renaming for consistency Created 6 years, 10 months ago

Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.

Jump to:

Index: Source/core/editing/VisibleUnits.cpp

diff --git a/Source/core/editing/VisibleUnits.cpp b/Source/core/editing/VisibleUnits.cpp

index 49923bfbf56a72aab4a0a8e3eb364419a1d62650..7bb622b8286f2e42327895c23a3bc599045e355a 100644

--- a/Source/core/editing/VisibleUnits.cpp

+++ b/Source/core/editing/VisibleUnits.cpp

@@ -1002,7 +1002,7 @@ VisiblePosition nextLinePosition(const VisiblePosition &visiblePosition, int lin

if (!root) {

// FIXME: We need do the same in previousLinePosition.

- Node* child = node->childNode(p.deprecatedEditingOffset());

+ Node* child = node->traverseToChildAt(p.deprecatedEditingOffset());

node = child ? child : &node->lastDescendant();

Position position = nextRootInlineBoxCandidatePosition(node, visiblePosition, editableType);

if (position.isNotNull()) {

« no previous file with comments | « Source/core/editing/TextIterator.cpp ('k') | Source/core/editing/htmlediting.cpp » ('j') | no next file with comments »