Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(58)

Side by Side Diff: Source/core/rendering/RenderReplaced.cpp

Issue 171773008: Rename childNodeCount() / childNode() methods for clarity (Closed) Base URL: svn://svn.chromium.org/blink/trunk
Patch Set: Further renaming for consistency Created 6 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View unified diff | Download patch | Annotate | Revision Log
« no previous file with comments | « Source/core/rendering/RenderObject.cpp ('k') | Source/core/rendering/RenderTreeAsText.cpp » ('j') | no next file with comments »
Toggle Intra-line Diffs ('i') | Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
OLDNEW
1 /* 1 /*
2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org) 2 * Copyright (C) 1999 Lars Knoll (knoll@kde.org)
3 * Copyright (C) 2000 Dirk Mueller (mueller@kde.org) 3 * Copyright (C) 2000 Dirk Mueller (mueller@kde.org)
4 * Copyright (C) 2004, 2006, 2007 Apple Inc. All rights reserved. 4 * Copyright (C) 2004, 2006, 2007 Apple Inc. All rights reserved.
5 * Copyright (C) Research In Motion Limited 2011-2012. All rights reserved. 5 * Copyright (C) Research In Motion Limited 2011-2012. All rights reserved.
6 * 6 *
7 * This library is free software; you can redistribute it and/or 7 * This library is free software; you can redistribute it and/or
8 * modify it under the terms of the GNU Library General Public 8 * modify it under the terms of the GNU Library General Public
9 * License as published by the Free Software Foundation; either 9 * License as published by the Free Software Foundation; either
10 * version 2 of the License, or (at your option) any later version. 10 * version 2 of the License, or (at your option) any later version.
(...skipping 583 matching lines...) Expand 10 before | Expand all | Expand 10 after
594 if (s == SelectionNone) 594 if (s == SelectionNone)
595 return false; 595 return false;
596 if (s == SelectionInside) 596 if (s == SelectionInside)
597 return true; 597 return true;
598 598
599 int selectionStart, selectionEnd; 599 int selectionStart, selectionEnd;
600 selectionStartEnd(selectionStart, selectionEnd); 600 selectionStartEnd(selectionStart, selectionEnd);
601 if (s == SelectionStart) 601 if (s == SelectionStart)
602 return selectionStart == 0; 602 return selectionStart == 0;
603 603
604 int end = node()->hasChildNodes() ? node()->childNodeCount() : 1; 604 int end = node()->hasChildren() ? node()->countChildren() : 1;
605 if (s == SelectionEnd) 605 if (s == SelectionEnd)
606 return selectionEnd == end; 606 return selectionEnd == end;
607 if (s == SelectionBoth) 607 if (s == SelectionBoth)
608 return selectionStart == 0 && selectionEnd == end; 608 return selectionStart == 0 && selectionEnd == end;
609 609
610 ASSERT(0); 610 ASSERT(0);
611 return false; 611 return false;
612 } 612 }
613 613
614 LayoutRect RenderReplaced::clippedOverflowRectForRepaint(const RenderLayerModelO bject* repaintContainer) const 614 LayoutRect RenderReplaced::clippedOverflowRectForRepaint(const RenderLayerModelO bject* repaintContainer) const
(...skipping 14 matching lines...) Expand all
629 629
630 if (style()) { 630 if (style()) {
631 if (v) 631 if (v)
632 r.inflate(style()->outlineSize()); 632 r.inflate(style()->outlineSize());
633 } 633 }
634 computeRectForRepaint(repaintContainer, r); 634 computeRectForRepaint(repaintContainer, r);
635 return r; 635 return r;
636 } 636 }
637 637
638 } 638 }
OLDNEW
« no previous file with comments | « Source/core/rendering/RenderObject.cpp ('k') | Source/core/rendering/RenderTreeAsText.cpp » ('j') | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698