Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(335)

Issue 171263004: Adding Blink-side support for EXT_shader_texture_lod (Closed)

Created:
6 years, 10 months ago by bajones
Modified:
6 years, 8 months ago
CC:
blink-reviews, Nils Barth (inactive), kojih, arv+blink, jsbell+bindings_chromium.org, sof, abarth-chromium, aandrey+blink_chromium.org, marja+watch_chromium.org, dglazkov+blink, Rik, adamk+blink_chromium.org, Nate Chapin, watchdog-blink-watchlist_google.com, Inactive
Visibility:
Public.

Description

Adding Blink-side support for EXT_shader_texture_lod BUG=344583 Committed: https://src.chromium.org/viewvc/blink?view=rev&revision=171465

Patch Set 1 #

Patch Set 2 : Rebased #

Total comments: 1

Patch Set 3 : Fixed wrong extension string #

Unified diffs Side-by-side diffs Delta from patch set Stats (+87 lines, -3 lines) Patch
M Source/bindings/v8/custom/V8WebGLRenderingContextCustom.cpp View 1 2 chunks +5 lines, -0 lines 0 comments Download
M Source/core/core.gypi View 1 2 chunks +3 lines, -0 lines 0 comments Download
A Source/core/html/canvas/EXTShaderTextureLOD.h View 1 1 chunk +29 lines, -0 lines 0 comments Download
A Source/core/html/canvas/EXTShaderTextureLOD.cpp View 1 2 1 chunk +42 lines, -0 lines 0 comments Download
A + Source/core/html/canvas/EXTShaderTextureLOD.idl View 1 1 chunk +2 lines, -3 lines 0 comments Download
M Source/core/html/canvas/WebGLExtensionName.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContext.cpp View 1 2 chunks +2 lines, -0 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.h View 1 1 chunk +1 line, -0 lines 0 comments Download
M Source/core/html/canvas/WebGLRenderingContextBase.cpp View 1 1 chunk +1 line, -0 lines 0 comments Download

Messages

Total messages: 7 (0 generated)
bajones
Developer-requested extension with upcoming ANGLE implementation. Will be landing in Firefox soon as well. marja@: ...
6 years, 8 months ago (2014-04-10 20:36:01 UTC) #1
Ken Russell (switch to Gerrit)
LGTM with one correction. https://codereview.chromium.org/171263004/diff/40001/Source/core/html/canvas/EXTShaderTextureLOD.cpp File Source/core/html/canvas/EXTShaderTextureLOD.cpp (right): https://codereview.chromium.org/171263004/diff/40001/Source/core/html/canvas/EXTShaderTextureLOD.cpp#newcode15 Source/core/html/canvas/EXTShaderTextureLOD.cpp:15: context->extensionsUtil()->ensureExtensionEnabled("GL_EXT_texture_filter_anisotropic"); I think you mean ...
6 years, 8 months ago (2014-04-10 21:43:03 UTC) #2
haraken
bindings/ LGTM.
6 years, 8 months ago (2014-04-10 23:11:33 UTC) #3
bajones
The CQ bit was checked by bajones@chromium.org
6 years, 8 months ago (2014-04-11 03:15:08 UTC) #4
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/171263004/60001
6 years, 8 months ago (2014-04-11 03:15:11 UTC) #5
commit-bot: I haz the power
CQ is trying da patch. Follow status at https://chromium-status.appspot.com/cq/bajones@chromium.org/171263004/60001
6 years, 8 months ago (2014-04-11 23:54:42 UTC) #6
commit-bot: I haz the power
6 years, 8 months ago (2014-04-14 14:45:30 UTC) #7
Message was sent while issue was closed.
Change committed as 171465

Powered by Google App Engine
This is Rietveld 408576698