Issue 1702003004: Replace update menu badge

Keyboard Shortcuts

	File
u :	up to issue
j / k :	jump to file after / before current file
J / K :	jump to next file with a comment after / before current file
	Side-by-side diff
i :	toggle intra-line diffs
e :	expand all comments
c :	collapse all comments
s :	toggle showing all comments
n / p :	next / previous diff chunk or comment
N / P :	next / previous comment
<Up> / <Down> :	next / previous line

	Issue
u :	up to list of issues
j / k :	jump to patch after / before current patch
o / <Enter> :	open current patch in side-by-side view
i :	open current patch in unified diff view

	Issue List
j / k :	jump to issue after / before current issue
o / <Enter> :	open current issue

Issue 1702003004: Replace update menu badge (Closed)

Created:
4 years, 10 months ago by Theresa

Modified:
4 years, 10 months ago

Reviewers:
gone

CC:
chromium-reviews

Base URL:
https://chromium.googlesource.com/a/chromium/src.git@2623

Target Ref:
refs/pending/branch-heads/2623

Project:
chromium

Visibility:
Public.

More Reviews

Description

Replace update menu badge Replace the current update menu badge with a different animated badge. BUG=586325 TBR=dfalcantara@chromium.org Review URL: https://codereview.chromium.org/1694673002 Cr-Commit-Position: refs/heads/master@{#375619} Committed: https://chromium.googlesource.com/chromium/src/+/15e8061ec1521a9dccbdf10f6f30476858c54c50

Patch Set 1 #

Created: 4 years, 10 months ago

Download [raw] [tar.bz2]

	Unified diffs	Side-by-side diffs	Stats (+421 lines, -157 lines)			Patch
D	chrome/android/java/res/drawable-hdpi/badge_update.png	View	Binary file		0 comments	Download
A	chrome/android/java/res/drawable-hdpi/badge_update_dark.png	View	Binary file		0 comments	Download
A	chrome/android/java/res/drawable-hdpi/badge_update_light.png	View	Binary file		0 comments	Download
D	chrome/android/java/res/drawable-mdpi/badge_update.png	View	Binary file		0 comments	Download
A	chrome/android/java/res/drawable-mdpi/badge_update_dark.png	View	Binary file		0 comments	Download
A	chrome/android/java/res/drawable-mdpi/badge_update_light.png	View	Binary file		0 comments	Download
D	chrome/android/java/res/drawable-xhdpi/badge_update.png	View	Binary file		0 comments	Download
A	chrome/android/java/res/drawable-xhdpi/badge_update_dark.png	View	Binary file		0 comments	Download
A	chrome/android/java/res/drawable-xhdpi/badge_update_light.png	View	Binary file		0 comments	Download
D	chrome/android/java/res/drawable-xxhdpi/badge_update.png	View	Binary file		0 comments	Download
A	chrome/android/java/res/drawable-xxhdpi/badge_update_dark.png	View	Binary file		0 comments	Download
A	chrome/android/java/res/drawable-xxhdpi/badge_update_light.png	View	Binary file		0 comments	Download
D	chrome/android/java/res/drawable-xxxhdpi/badge_update.png	View	Binary file		0 comments	Download
A	chrome/android/java/res/drawable-xxxhdpi/badge_update_dark.png	View	Binary file		0 comments	Download
A	chrome/android/java/res/drawable-xxxhdpi/badge_update_light.png	View	Binary file		0 comments	Download
M	chrome/android/java/res/layout-sw600dp/toolbar.xml	View	1 chunk	+7 lines, -8 lines	0 comments	Download
M	chrome/android/java/res/layout/location_bar.xml	View	1 chunk	+7 lines, -7 lines	0 comments	Download
M	chrome/android/java/res/layout/toolbar.xml	View	1 chunk	+7 lines, -10 lines	0 comments	Download
M	chrome/android/java/res/values-v17/styles.xml	View	1 chunk	+14 lines, -9 lines	0 comments	Download
M	chrome/android/java/res/values/dimens.xml	View	1 chunk	+1 line, -2 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/ChromeActivity.java	View	2 chunks	+11 lines, -1 line	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/omaha/UpdateMenuItemHelper.java	View	5 chunks	+93 lines, -52 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/omnibox/LocationBarPhone.java	View	4 chunks	+105 lines, -11 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/toolbar/CustomTabToolbar.java	View	1 chunk	+10 lines, -1 line	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/toolbar/Toolbar.java	View	1 chunk	+11 lines, -3 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarLayout.java	View	4 chunks	+93 lines, -9 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java	View	8 chunks	+52 lines, -40 lines	0 comments	Download
M	chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java	View	4 chunks	+10 lines, -4 lines	0 comments	Download

Messages

Total messages: 2 (1 generated)

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages

Theresa

4 years, 10 months ago (2016-02-17 02:32:16 UTC) #2

Message was sent while issue was closed.

Committed patchset #1 (id:1) manually as
15e8061ec1521a9dccbdf10f6f30476858c54c50 (presubmit successful).

Expand Messages | Collapse Messages | Show Generated Messages | Hide Generated Messages