Chromium Code Reviews
chromiumcodereview-hr@appspot.gserviceaccount.com (chromiumcodereview-hr) | Please choose your nickname with Settings | Help | Chromium Project | Gerrit Changes | Sign out
(4560)

Unified Diff: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java

Issue 1702003004: Replace update menu badge (Closed) Base URL: https://chromium.googlesource.com/a/chromium/src.git@2623
Patch Set: Created 4 years, 10 months ago
Use n/p to move between diff chunks; N/P to move between comments. Draft comments are only viewable by you.
Jump to:
View side-by-side diff with in-line comments
Download patch
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java ('k') | no next file » | no next file with comments »
Expand Comments ('e') | Collapse Comments ('c') | Show Comments Hide Comments ('s')
Index: chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
diff --git a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
index d834def695084d2ab8c6574fd3e10c837caffb19..f687616e2702ec88dd7d4f28c0ee2633d8e5a9c4 100644
--- a/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
+++ b/chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarTablet.java
@@ -269,6 +269,7 @@ public class ToolbarTablet extends ToolbarLayout implements OnClickListener {
}
} else if (mAccessibilitySwitcherButton == v) {
if (mTabSwitcherListener != null) {
+ cancelAppMenuUpdateBadgeAnimation();
mTabSwitcherListener.onClick(mAccessibilitySwitcherButton);
}
}
@@ -305,6 +306,9 @@ public class ToolbarTablet extends ToolbarLayout implements OnClickListener {
mAccessibilitySwitcherButton.setImageDrawable(
incognito ? mTabSwitcherButtonDrawableLight : mTabSwitcherButtonDrawable);
mLocationBar.updateVisualsForState();
+ if (mShowMenuBadge) {
+ setAppMenuUpdateBadgeDrawable(incognito);
+ }
mUseLightColorAssets = incognito;
}
mLocationBar.setUrlBarFocus(false);
@@ -364,15 +368,14 @@ public class ToolbarTablet extends ToolbarLayout implements OnClickListener {
mForwardButton.setEnabled(false);
mReloadButton.setEnabled(false);
mLocationBar.getContainerView().setVisibility(View.INVISIBLE);
- if (mShowMenuBadge && mUnbadgedMenuButtonDrawable != null) {
- mMenuButton.setImageDrawable(mUnbadgedMenuButtonDrawable);
+ if (mShowMenuBadge) {
mMenuBadge.setVisibility(View.GONE);
}
} else {
mIsInTabSwitcherMode = false;
mLocationBar.getContainerView().setVisibility(View.VISIBLE);
if (mShowMenuBadge) {
- setAppMenuUpdateBadgeToVisible();
+ setAppMenuUpdateBadgeToVisible(false);
}
}
}
@@ -417,7 +420,10 @@ public class ToolbarTablet extends ToolbarLayout implements OnClickListener {
public void showAppMenuUpdateBadge() {
super.showAppMenuUpdateBadge();
if (!mIsInTabSwitcherMode) {
- setAppMenuUpdateBadgeToVisible();
+ if (mUseLightColorAssets) {
+ setAppMenuUpdateBadgeDrawable(mUseLightColorAssets);
+ }
+ setAppMenuUpdateBadgeToVisible(true);
}
}
}
« no previous file with comments | « chrome/android/java/src/org/chromium/chrome/browser/toolbar/ToolbarPhone.java ('k') | no next file » | no next file with comments »

Powered by Google App Engine
This is Rietveld 408576698